contrib: correct default build path in man pages #31255

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:20241108-manpages changing 1 files +1 −1
  1. rkrux commented at 10:16 AM on November 8, 2024: contributor

    The gen-manpages.py script is unable to find the executables because it tries to search in /bitcoin/src when no custom BUILDDIR is set. With the new build process in place, the default build dir is now set to /bitcoin/build.

    Prior to this change, the script stopped with a not found or not an executable error. Now it generates the man pages without needing to explicitly set BUILDDIR variable.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. contrib: correct default build path in man pages
    The `gen-manpages.py` script is unable to find
    the executables because it tries to search in
    `/bitcoin/src` when no custom `BUILDDIR` is set.
    With the new build process in place, the default
    build dir is now set to `/bitcoin/build`.
    
    Prior to this change, the script stopped with a
    `not found or not an executable` error. Now it
    generates the man pages without needing to
    explicitly set `BUILDDIR` variable.
    189433b08b
  3. DrahtBot commented at 10:16 AM on November 8, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31255.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Scripts and tools on Nov 8, 2024
  5. fanquake commented at 10:19 AM on November 8, 2024: member

    Thanks, however this is part of #30986.

  6. fanquake closed this on Nov 8, 2024

  7. rkrux commented at 10:26 AM on November 8, 2024: contributor

    Thanks, however this is part of #30986.

    Oh I see, I will take a look at it, thank you.

  8. bitcoin locked this on Nov 8, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me