ci: make ctest stop on failure #31257

1. 
   furszy commented at 6:12 pm on November 8, 2024: member

   Make ctest stops when the first failure happens. Wasting less resources and notifying the developer faster when a failure occurs.
2. ci: make ctest stop on failure

   Wastes less resources and notifies the developer faster when
   a failure occurs.

   36a22e5683
3. 
   DrahtBot commented at 6:12 pm on November 8, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31257.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, tdb3

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31182 (ci: Place datadirs for tests under tmpfs by maflcko)
   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Nov 8, 2024
5. 
   maflcko commented at 12:10 pm on November 9, 2024: member

   lgtm ACK 36a22e5683375b7925767de9daa9df4c48831c15

   I think the same happened when the project was using make, but I haven’t double-checked.

6. tdb3 approved
7. 
   tdb3 commented at 7:08 pm on November 10, 2024: contributor

   code review and test ACK 36a22e5683375b7925767de9daa9df4c48831c15

   • Grepped for ctest in other directories (in case other files should be adjusted). Didn’t see anything else to update.
   • Sanity checked by inserting an intentional failure (BOOST_CHECK_EQUAL(1, 2)) into addrman_simple and ran ctest locally as defined in the CI ymls to confirm the commands with --stop-on-failure behave as expected (i.e. stop early). Behaved as expected.
8. fanquake merged this on Nov 11, 2024
9. fanquake closed this on Nov 11, 2024

   ---

Contributors
furszy DrahtBot maflcko tdb3

Labels
Tests