ci: make ctest stop on failure #31257

Make ctest stops when the first failure happens. Wasting less resources and notifying the developer faster when a failure occurs.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31257.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #31182 (ci: Place datadirs for tests under tmpfs by maflcko)
• #28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

lgtm ACK 36a22e5683375b7925767de9daa9df4c48831c15

I think the same happened when the project was using make, but I haven't double-checked.

code review and test ACK 36a22e5683375b7925767de9daa9df4c48831c15

• Grepped for ctest in other directories (in case other files should be adjusted). Didn't see anything else to update.
• Sanity checked by inserting an intentional failure (BOOST_CHECK_EQUAL(1, 2)) into addrman_simple and ran ctest locally as defined in the CI ymls to confirm the commands with --stop-on-failure behave as expected (i.e. stop early). Behaved as expected.