doc: Fixup bitcoin-wallet manpage chain selection args #31264

1. 
   maflcko commented at 12:39 pm on November 9, 2024: member

   The sentence is missing -testnet4 and -chain. Instead of duplicating the full list (and having to keep it in sync), just refer to them as (test)chain selection arguments.
2. doc: Fixup bitcoin-wallet manpage chain selection args fa729ab4a2
3. 
   DrahtBot commented at 12:39 pm on November 9, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31264.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	willcl-ark, tdb3, rkrux
   Concept ACK	edilmedeiros

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Docs on Nov 9, 2024
5. 
   edilmedeiros commented at 1:36 pm on November 9, 2024: contributor

   Concept ACK.

   I understand and like the rational for not being repetitive, but don’t you think the terminology might be confusing? I could not think of any better alternatives, though.

6. willcl-ark approved
7. 
   willcl-ark commented at 2:41 pm on November 10, 2024: member

   utACK fa729ab4a276c3462e390bf2fab6cad93d3a590d

   Thanks Marco, this makes sense to me.

8. tdb3 approved
9. 
   tdb3 commented at 6:12 pm on November 10, 2024: contributor

   Code Review ACK fa729ab4a276c3462e390bf2fab6cad93d3a590d

   Would also support adding an example:

   0- "To change the target wallet, use the -datadir, -wallet and (test)chain selection arguments.\n"
   1+ "To change the target wallet, use the -datadir, -wallet and (test)chain selection arguments (e.g. -signet).\n"
   

10. Abdulkbk approved
11. in src/bitcoin-wallet.cpp:1 in fa729ab4a2

    0@@ -1,4 +1,4 @@
    1-// Copyright (c) 2016-2022 The Bitcoin Core developers
    2+// Copyright (c) 2016-present The Bitcoin Core developers
    

    ---

    ---

    

    rkrux commented at 5:47 am on November 11, 2024:

    I had noticed -2022 in few others files as well, wonder why they don’t didn’t say -present earlier. Good to see these getting fixed one by one.

    ---

    

    willcl-ark commented at 10:58 am on November 11, 2024:

    We generally address these as and when files are touched (and folks remember).
12. rkrux approved
13. 
    rkrux commented at 5:53 am on November 11, 2024: none

    crACK fa729ab4a276c3462e390bf2fab6cad93d3a590d
14. fanquake merged this on Nov 11, 2024
15. fanquake closed this on Nov 11, 2024

    ---

16. maflcko deleted the branch on Nov 11, 2024

Contributors
maflcko DrahtBot edilmedeiros willcl-ark tdb3 Abdulkbk rkrux

Labels
Docs