doc: Fixup bitcoin-wallet manpage chain selection args #31264

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2411-doc-wallet-tool changing 1 files +2 −2
  1. maflcko commented at 12:39 PM on November 9, 2024: member

    The sentence is missing -testnet4 and -chain. Instead of duplicating the full list (and having to keep it in sync), just refer to them as (test)chain selection arguments.

  2. doc: Fixup bitcoin-wallet manpage chain selection args fa729ab4a2
  3. DrahtBot commented at 12:39 PM on November 9, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31264.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK willcl-ark, tdb3, rkrux
    Concept ACK edilmedeiros

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Docs on Nov 9, 2024
  5. edilmedeiros commented at 1:36 PM on November 9, 2024: contributor

    Concept ACK.

    I understand and like the rational for not being repetitive, but don't you think the terminology might be confusing? I could not think of any better alternatives, though.

  6. willcl-ark approved
  7. willcl-ark commented at 2:41 PM on November 10, 2024: member

    utACK fa729ab4a276c3462e390bf2fab6cad93d3a590d

    Thanks Marco, this makes sense to me.

  8. tdb3 approved
  9. tdb3 commented at 6:12 PM on November 10, 2024: contributor

    Code Review ACK fa729ab4a276c3462e390bf2fab6cad93d3a590d

    Would also support adding an example:

    - "To change the target wallet, use the -datadir, -wallet and (test)chain selection arguments.\n"
+ "To change the target wallet, use the -datadir, -wallet and (test)chain selection arguments (e.g. -signet).\n"
  10. Abdulkbk approved
  11. in src/bitcoin-wallet.cpp:1 in fa729ab4a2 
       0 | @@ -1,4 +1,4 @@
   1 | -// Copyright (c) 2016-2022 The Bitcoin Core developers
   2 | +// Copyright (c) 2016-present The Bitcoin Core developers
    rkrux commented at 5:47 AM on November 11, 2024:

    I had noticed -2022 in few others files as well, wonder why they ~don't~ didn't say -present earlier. Good to see these getting fixed one by one.

    willcl-ark commented at 10:58 AM on November 11, 2024:

    We generally address these as and when files are touched (and folks remember).

  12. rkrux approved
  13. rkrux commented at 5:53 AM on November 11, 2024: contributor

    crACK fa729ab4a276c3462e390bf2fab6cad93d3a590d

  14. fanquake merged this on Nov 11, 2024
  15. fanquake closed this on Nov 11, 2024
  16. maflcko deleted the branch on Nov 11, 2024
  17. TheCharlatan referenced this in commit a73b2bd0f0 on Nov 14, 2024
  18. bug-castercv502 referenced this in commit fdcc066ca0 on Sep 28, 2025
  19. bitcoin locked this on Nov 11, 2025
Contributors
maflckoDrahtBotedilmedeiroswillcl-arktdb3Abdulkbkrkrux
Labels
Docs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me