Revert recent json-spirit changes #3127

pull jgarzik wants to merge 2 commits into bitcoin:master from jgarzik:smells-like-json-spirit changing 18 files +398 −697

jgarzik commented at 9:50 AM on October 22, 2013: contributor

The changes broke amounts in 'listtransactions', and other places. See issue #3126

Verified that this simple 'git revert' of the two json-spirit commits fixes the issue.

Revert "Switch to using raw_utf8"

This reverts commit 2ecb7555a9df1e843fd25f588819e4ca1d94b266.

0db9a805bd

Revert "JSON Spirit updated to v4.06"

This reverts commit 2227389fa8fa1b9ff19234838fc7b641e935125b.

406b1f05f6

laanwj commented at 9:59 AM on October 22, 2013: member

ACK
BitcoinPullTester commented at 10:27 AM on October 22, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/406b1f05f61a7bba7ef6860c031a7a7c3e019100 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gmaxwell commented at 10:34 AM on October 22, 2013: contributor

ACK (untested, but it's just a revert)
laanwj commented at 10:46 AM on October 22, 2013: member

I guess we should add a test to prevent this from happening in the future.
jgarzik commented at 10:48 AM on October 22, 2013: contributor

Do we have any way to test RPC in the current codebase?
laanwj commented at 11:36 AM on October 22, 2013: member

Well, there is rpc_tests: https://github.com/bitcoin/bitcoin/blob/master/src/test/rpc_tests.cpp But there is nothing that tests the JSON parsing / formatting explicitly.
jgarzik referenced this in commit fcb9f26466 on Oct 22, 2013
jgarzik merged this on Oct 22, 2013
jgarzik closed this on Oct 22, 2013
Bushstar referenced this in commit 47c7f421f7 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors