fuzz: Implement G_TEST_GET_FULL_NAME #31333

1. 
   hodlinator commented at 2:17 pm on November 20, 2024: contributor

   Catching up to bench & unit tests. Makes for more orderly paths for fuzz tests using BasicTestingSetup.

   Before

   0/tmp/test_common bitcoin/0748ae43ef8fa80703bc/regtest/blocks/xor.dat
   

   After

   0/tmp/test_common bitcoin/tx_pool_standard/f18b3744625e0600eb0c/regtest/blocks/xor.dat
   

2. fuzz: Implement G_TEST_GET_FULL_NAME

   When BasicTestingSetup is used in fuzz-tests it will now create test directories containing the fuzz target names. Example:
   /tmp/test_common bitcoin/tx_package_eval/153d7906294f7d0606a7/
   
   This is already implemented for bench and unit tests.

   92d3d691f0
3. 
   DrahtBot commented at 2:17 pm on November 20, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31333.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	kevkevinpal, furszy, tdb3, dergoegge, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30882 (wip: Split fuzz binary (take 2) by dergoegge)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Nov 20, 2024
5. 
   kevkevinpal commented at 2:36 pm on November 20, 2024: contributor

   ACK 92d3d69

   This helps clean up the /tmp/test_common bitcoin dir and makes it easier to know which directory is running which test

   I tested by running an individual fuzz test with multiple workers and observing the /tmp dir FUZZ=utxo_total_supply ./build_fuzz/src/test/fuzz/fuzz -jobs=8 -workers=8

   I also tested by running the fuzz test_runner.py and observing the /tmp dir ./build_fuzz/test/fuzz/test_runner.py ./qa-assets/fuzz_seed_corpus/

   Also the macOS ci test failing seems unrelated to the changes

6. 
   furszy commented at 6:28 pm on November 20, 2024: member

   utACK 92d3d691f097ead8e5ae571eb9bf691133a6aa49
7. tdb3 approved
8. 
   tdb3 commented at 11:26 pm on November 20, 2024: contributor

   ACK 92d3d691f097ead8e5ae571eb9bf691133a6aa49

   Lightly tested by running with FUZZ=utxo_snapshot. Verified the observation in the description <name>/<random>.

9. dergoegge approved
10. 
    dergoegge commented at 10:07 am on November 21, 2024: member

    utACK 92d3d691f097ead8e5ae571eb9bf691133a6aa49
11. brunoerg approved
12. 
    brunoerg commented at 1:45 pm on November 21, 2024: contributor

    code review ACK 92d3d691f097ead8e5ae571eb9bf691133a6aa49
13. fanquake merged this on Nov 21, 2024
14. fanquake closed this on Nov 21, 2024

    ---

15. hodlinator deleted the branch on Nov 21, 2024

Contributors
hodlinator DrahtBot kevkevinpal furszy tdb3 dergoegge brunoerg

Labels
Tests