macOS: swap docs & CI from pkg-config to pkgconf #31335

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:pkg_config_to_pkg_conf changing 2 files +3 −2
  1. fanquake commented at 3:19 pm on November 20, 2024: member

    Migrate the macOS build docs and CI from pkg-config to pkgconf. As the former now just redirects to the later.

    Upstream is currently mass-migrating its formula. i.e https://github.com/Homebrew/homebrew-core/pull/198317.

    Add a workaround for #31334.

  2. DrahtBot commented at 3:19 pm on November 20, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31335.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator
    Concept ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30975 (Add multiprocess binaries to release build by Sjors)
    • #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
    • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
    • #10102 (Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. fanquake force-pushed on Nov 20, 2024
  4. fanquake force-pushed on Nov 20, 2024
  5. hebasto commented at 3:43 pm on November 20, 2024: member
    Concept ACK.
  6. doc: migrate from pkg-config to pkgconf in macOS build docs
    Brew has migrated to using the later:
    ```bash
    brew info pkg-config
    ==> pkgconf: stable 2.3.0 (bottled), HEAD
    Package compiler and linker metadata toolkit
    https://github.com/pkgconf/pkgconf
    ```
    
    See
    43a21a8cae
  7. ci: migrate macOS build from pkg-config to pkgconf
    As pkg-config is now just redirected to the later.
    
    At the same time, add a workaround to fix: #31334.
    fa9e7fb167
  8. fanquake commented at 3:49 pm on November 20, 2024: member
    Given that the CI is now working here, (and #31334 wasn’t one-off, it’s happening for all new pushes (i.e #29881)), have updated the commit message and PR description.
  9. fanquake force-pushed on Nov 20, 2024
  10. hodlinator approved
  11. hodlinator commented at 11:24 pm on November 20, 2024: contributor

    utACK fa9e7fb167d7a1c476af931610ccbae39e29b964

    Don’t have a valid Mac to test on but change looks very straightforward and is in a similar vane to the linked upstream change.

  12. DrahtBot requested review from hebasto on Nov 20, 2024
  13. hodlinator commented at 11:28 pm on November 20, 2024: contributor

    Add a workaround for #31334.

    Sounds like a TODO? Why not “Fixes #31334”?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me