test: Deduplicate assert_mempool_contents() #31338

pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2024/11/dedup_assert_mempool_contents changing 1 files +2 −9

hodlinator commented at 11:07 AM on November 21, 2024: contributor

Recently added mempool_util implementation probably evolved in parallel with the package RBF one before being submitted as part of ephemeral dust in e2e30e89ba4b9bdbcabaf5b4346610922f0728bb (related comments: #30239 (review), #31279#pullrequestreview-2445579323).

functional test: Deduplicate assert_mempool_contents()

Recently added mempool_util implementation probably evolved in parallel with the package RBF one before being submitted as part of ephemeral dust in e2e30e89ba4b9bdbcabaf5b4346610922f0728bb.

a0eafc10f9

DrahtBot commented at 11:07 AM on November 21, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31338.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK l0rinc, theStack, instagibbs, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Nov 21, 2024

Type	Reviewers
ACK	l0rinc, theStack, instagibbs, achow101

in test/functional/mempool_package_rbf.py:41 in a0eafc10f9

  45 | -            expected = []
  46 | -        mempool = self.nodes[0].getrawmempool(verbose=False)
  47 | -        assert_equal(len(mempool), len(expected))
  48 | -        for tx in expected:
  49 | -            assert tx.rehash() in mempool
  50 | +        mempool_util.assert_mempool_contents(self, self.nodes[0], expected, sync=False)

l0rinc commented at 12:02 PM on November 21, 2024:

inlining assert_mempool_contents and removing dead code results in the exact same code as before 👍

l0rinc approved
l0rinc commented at 12:02 PM on November 21, 2024: contributor

ACK a0eafc10f94362408f54195ffd5a9237dc1ef638
theStack approved
theStack commented at 12:50 PM on November 21, 2024: contributor

ACK a0eafc10f94362408f54195ffd5a9237dc1ef638

Thanks for following up!
instagibbs commented at 7:29 PM on November 21, 2024: member

ACK a0eafc10f94362408f54195ffd5a9237dc1ef638

thanks for opening this
achow101 commented at 11:16 PM on November 21, 2024: member

ACK a0eafc10f94362408f54195ffd5a9237dc1ef638
achow101 merged this on Nov 22, 2024
achow101 closed this on Nov 22, 2024
hodlinator deleted the branch on Nov 23, 2024
TheCharlatan referenced this in commit bd64a555d7 on Dec 3, 2024
TheCharlatan referenced this in commit 15319cfcd5 on Dec 4, 2024
stickies-v referenced this in commit f6b6da7935 on Dec 18, 2024
stickies-v referenced this in commit 6816a65596 on Dec 18, 2024
stickies-v referenced this in commit de777e8ed6 on Dec 18, 2024
bug-castercv502 referenced this in commit c87bcd9110 on Sep 28, 2025
bitcoin locked this on Nov 23, 2025

Contributors

Labels

Linked (view graph)

#30239 Ephemeral Dust #31279 policy: ephemeral dust followups

test: Deduplicate assert_mempool_contents() #31338

Code Coverage & Benchmarks

Reviews