mempool_util
implementation probably evolved in parallel with the package RBF one before being submitted as part of ephemeral dust in e2e30e89ba4b9bdbcabaf5b4346610922f0728bb (related comments: #30239 (review), #31279#pullrequestreview-2445579323).
test: Deduplicate assert_mempool_contents() #31338
pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2024/11/dedup_assert_mempool_contents changing 1 files +2 −9-
hodlinator commented at 11:07 am on November 21, 2024: contributorRecently added
-
functional test: Deduplicate assert_mempool_contents()
Recently added mempool_util implementation probably evolved in parallel with the package RBF one before being submitted as part of ephemeral dust in e2e30e89ba4b9bdbcabaf5b4346610922f0728bb.
-
DrahtBot commented at 11:07 am on November 21, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31338.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK l0rinc, theStack, instagibbs, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Tests on Nov 21, 2024
-
in test/functional/mempool_package_rbf.py:41 in a0eafc10f9
45- expected = [] 46- mempool = self.nodes[0].getrawmempool(verbose=False) 47- assert_equal(len(mempool), len(expected)) 48- for tx in expected: 49- assert tx.rehash() in mempool 50+ mempool_util.assert_mempool_contents(self, self.nodes[0], expected, sync=False)
l0rinc commented at 12:02 pm on November 21, 2024:inliningassert_mempool_contents
and removing dead code results in the exact same code as before 👍l0rinc approvedl0rinc commented at 12:02 pm on November 21, 2024: contributorACK a0eafc10f94362408f54195ffd5a9237dc1ef638theStack approvedtheStack commented at 12:50 pm on November 21, 2024: contributorACK a0eafc10f94362408f54195ffd5a9237dc1ef638
Thanks for following up!
instagibbs commented at 7:29 pm on November 21, 2024: memberACK a0eafc10f94362408f54195ffd5a9237dc1ef638
thanks for opening this
achow101 commented at 11:16 pm on November 21, 2024: memberACK a0eafc10f94362408f54195ffd5a9237dc1ef638achow101 merged this on Nov 22, 2024achow101 closed this on Nov 22, 2024
hodlinator deleted the branch on Nov 23, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me