Add coin-grinder example test #31352

1. 
   yancyribbens commented at 5:08 pm on November 22, 2024: contributor

   In understanding the coin-grinder algorithm, I find it useful to run the algorithm with the parameters given in the example code. I thing it would be useful to add to the test-framework.
2. 
   DrahtBot commented at 5:08 pm on November 22, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31352.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. test: Add coin-grinder example

   Adds a test that traces the example given in the documentation

   4435cbbe2d
4. yancyribbens force-pushed on Nov 22, 2024
5. 
   brunoerg commented at 11:33 am on November 26, 2024: contributor

   According to https://corecheck.dev/bitcoin/bitcoin/pulls/31352, this PR does not bring any new test coverage for coin selection. What are you exactly testing here that is not covered yet? If you simply are reproducing the example code, so I tend to concept NACK on adding this to the test, the example is only an example.
6. 
   yancyribbens commented at 5:34 pm on November 26, 2024: contributor

   If you simply are reproducing the example code, so I tend to concept NACK on adding this to the test, the example is only an example.

   That’s fair. I wanted a way to follow the example code to trace values during various assignments and conditions. I figured since I wrote the test it might be useful to add, although if not, I can still use it and we can close the PR.

7. yancyribbens closed this on Nov 27, 2024

   ---

Contributors
yancyribbens DrahtBot brunoerg