When no build targets are specified, it is reasonable to expect the configuration step to succeed and produce a build system that does not build any targets.
This PR updates the code to ensure this behaviour:
$ cmake -B build -G "Ninja" -DBUILD_DAEMON=OFF -DBUILD_CLI=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DENABLE_WALLET=OFF -DBUILD_TESTS=OFF
$ cmake --build build
ninja: no work to do.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31357.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | TheCharlatan, tdb3 |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
When no build targets are specified, it is reasonable to expect the configuration step to succeed...
The issue was reported offline by @TheCharlatan.
ACK ab5c63edccea7957e2c7b3b9d8b04655a7f82f22
light test ACK ab5c63edccea7957e2c7b3b9d8b04655a7f82f22
On master (dbc8ba12f3b3548dd6955293c5d650320ca39c5b):
Native (Make)
$ cmake -B build -DBUILD_DAEMON=OFF -DBUILD_CLI=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DENABLE_WALLET=OFF -DBUILD_TESTS=OFF
...
-- Configuring done
CMake Error at src/CMakeLists.txt:289 (target_link_libraries):
Target "bitcoin_node" links to:
libevent::core
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
$ cmake --build build
[100%] Building C object src/secp256k1/src/CMakeFiles/secp256k1_precomputed.dir/precomputed_ecmult.c.o
[100%] Building C object src/secp256k1/src/CMakeFiles/secp256k1_precomputed.dir/precomputed_ecmult_gen.c.o
[100%] Built target secp256k1_precomputed
[100%] Building C object src/secp256k1/src/CMakeFiles/secp256k1.dir/secp256k1.c.o
[100%] Linking C static library ../lib/libsecp256k1.a
[100%] Built target secp256k1
Ninja
$ cmake -B build -G "Ninja" -DBUILD_DAEMON=OFF -DBUILD_CLI=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DENABLE_WALLET=OFF -DBUILD_TESTS=OFF
...
-- Configuring done
CMake Error at src/CMakeLists.txt:289 (target_link_libraries):
Target "bitcoin_node" links to:
libevent::core
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
$ cmake --build build
ninja: error: loading 'build.ninja': No such file or directory
On PR branch (ab5c63edccea7957e2c7b3b9d8b04655a7f82f22): No error observed when generating the buildsystem (Make or Ninja)
Make
$ cmake --build build
<no output>
Ninja
$ cmake --build build
ninja: no work to do.