cmake, qt: Use absolute paths for includes in MOC-generated files #31361

1. 
   hebasto commented at 3:24 pm on November 24, 2024: member

   Fixes #31145.

   From the moc --help output:

   0  -p <path>                         Path prefix for included file.
   

2. cmake, qt: Use absolute paths for includes in MOC-generated files

   This change resolves build issues that occur when the source or build
   directory is symlinked.

   6f4128e3a8
3. 
   DrahtBot commented at 3:24 pm on November 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31361.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	laanwj, willcl-ark, TheCharlatan, BrandonOdiwuor

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. hebasto added the label Build system on Nov 24, 2024
5. 
   hebasto commented at 3:25 pm on November 24, 2024: member

   cc @laanwj
6. hebasto added this to the milestone 29.0 on Nov 24, 2024
7. 
   laanwj commented at 8:36 am on November 25, 2024: member

   Concept ACK, will test!
8. 
   laanwj commented at 3:35 pm on November 25, 2024: member

   Tested -DBUILD_GUI=ON builds:

   • make + whole sourcedir in symlink → works
   • ninja + whole sourcedir in symlink → works
   • make + build directory is symlink → works
   • ninja + build directory is symlink → works

   Tested ACK 6f4128e3a838d03f46d397c15bc5333287e14863

9. willcl-ark approved
10. 
    willcl-ark commented at 2:08 pm on November 28, 2024: member

    tACK 6f4128e3a838d03f46d397c15bc5333287e14863

    Tested building using a symlinked build dir using Ninja. Failures I experienced in #31145 build successfully with this patch.

11. 
    Sjors commented at 3:16 pm on November 28, 2024: member

    See #31050, this doesn’t fix the scenario where the whole source dir is a symlink for me on macOS 13.7. But it’s good that it does fix other things.

    Maybe something in depends needs a similar change?

12. TheCharlatan approved
13. 
    TheCharlatan commented at 2:06 pm on November 29, 2024: contributor

    ACK 6f4128e3a838d03f46d397c15bc5333287e14863
14. BrandonOdiwuor approved
15. 
    BrandonOdiwuor commented at 8:16 pm on November 29, 2024: contributor

    ACK 6f4128e3a838d03f46d397c15bc5333287e14863
16. fanquake merged this on Dec 2, 2024
17. fanquake closed this on Dec 2, 2024

    ---

18. hebasto deleted the branch on Dec 2, 2024

Contributors
hebasto DrahtBot laanwj willcl-ark Sjors TheCharlatan BrandonOdiwuor

Labels
Build system

Milestone
29.0