TxData or the block pointer needs to be taken from the ChainstateManager and passed in. This is currently verbose and may become even more verbose if the function is reworked in the future. As the function can not be called without a ChainstateManager in production code anyway, make it a member function on the class.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31393.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | ryanofsky, TheCharlatan, danielabrozzoni |
| Concept ACK | mzumsande |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
2962@@ -2963,6 +2963,7 @@ void Chainstate::PruneAndFlush()
2963 }
2964
2965 static void UpdateTipLog(
2966+ const ChainstateManager& chainman,
2967 const CCoinsViewCache& coins_tip,
2968 const CBlockIndex* tip,
2969 const CChainParams& params,
params, it’s no longer used
405@@ -406,9 +406,9 @@ class NodeImpl : public Node
406 }
407 std::unique_ptr<Handler> handleNotifyBlockTip(NotifyBlockTipFn fn) override
408 {
409- return MakeSignalHandler(::uiInterface.NotifyBlockTip_connect([fn](SynchronizationState sync_state, const CBlockIndex* block) {
410+ return MakeSignalHandler(::uiInterface.NotifyBlockTip_connect([fn, this](SynchronizationState sync_state, const CBlockIndex* block) {
411 fn(sync_state, BlockTip{block->nHeight, block->GetBlockTime(), block->GetBlockHash()},
412- GuessVerificationProgress(Params().TxData(), block));
413+ chainman().GuessVerificationProgress(block));
