test: Avoid logging error when logging error #31408

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2412-test-log-err changing 2 files +4 −3
  1. maflcko commented at 8:46 am on December 3, 2024: member

    Currently a logging error in the form of --- Logging error --- happens when an error is logged in the _on_data helper.

    Fix it by properly logging the error.

    Also, treat pylint errors as errors, to avoid this problem in the future.

    Can be tested by running p2p_addrv2_relay.py with the following example diff:

     0diff --git a/test/functional/test_framework/p2p.py b/test/functional/test_framework/p2p.py
     1index 523e1bd068..0f1eb29d13 100755
     2--- a/test/functional/test_framework/p2p.py
     3+++ b/test/functional/test_framework/p2p.py
     4@@ -137,7 +137,7 @@ MESSAGEMAP = {
     5     b"notfound": msg_notfound,
     6     b"ping": msg_ping,
     7     b"pong": msg_pong,
     8-    b"sendaddrv2": msg_sendaddrv2,
     9+    #b"sendaddrv2": msg_sendaddrv2,
    10     b"sendcmpct": msg_sendcmpct,
    11     b"sendheaders": msg_sendheaders,
    12     b"sendtxrcncl": msg_sendtxrcncl,
    
  2. test: Avoid logging error when logging error cccca8a77f
  3. DrahtBot commented at 8:46 am on December 3, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31408.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Dec 3, 2024
  5. fanquake approved
  6. fanquake commented at 5:16 pm on December 5, 2024: member
    ACK cccca8a77f3c1b22fb0ea825ca92aebd63b16d77
  7. fanquake merged this on Dec 5, 2024
  8. fanquake closed this on Dec 5, 2024

  9. maflcko deleted the branch on Dec 5, 2024
  10. achow101 added the label Needs backport (28.x) on Dec 11, 2024
  11. achow101 removed the label Needs backport (28.x) on Dec 11, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me