build: broken CMake *flags output #31482

issue fanquake openend this issue on December 12, 2024
  1. fanquake commented at 10:59 am on December 12, 2024: member

    Seen in CI runs, i.e https://cirrus-ci.com/task/5616358949388288?logs=configure#L309:

    0C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -fmacro-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -Werror $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:SHELL:-Xcompiler -pthread> $<$<AND:$<NOT:$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>>,$<NOT:$<COMPILE_LANGUAGE:Swift>>>:-pthread> -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety
    

    -Werror $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:SHELL:-Xcompiler -pthread> $<$<AND:$<NOT:$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>>,$<NOT:$<COMPILE_LANGUAGE:Swift>>>:-pthread> -Wall

    Haven’t checked if there is a (silent) effect on the build, but in any case, this output is broken.

  2. fanquake added the label Build system on Dec 12, 2024
  3. fanquake added this to the milestone 29.0 on Dec 12, 2024
  4. ArisAthena commented at 8:04 am on December 20, 2024: none

    Sir, It looks like there’s a problem with the compiler flags, particularly the redundancy in the -Werror and -pthread options.

    Why not see to it that the flags are correctly formatted and compatible with the compiler version being used. Specifically, checking the $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:SHELL:-Xcompiler -pthread> and $<$<AND:$<NOT:$<COMPILE_LANG_AND_ID:CUDA,NVIDIA»,$<NOT:$<COMPILE_LANGUAGE:Swift»>:-pthread> parts for redundancy?

  5. fanquake commented at 9:38 am on January 23, 2025: member
    One other report of this happening here: #31619 (comment).
  6. maflcko commented at 2:46 pm on February 21, 2025: member
    I guess this can be removed from the milestone? Surely, it is ugly, but harmless and the fix seems to be non-trivial and shouldn’t be a blocker?


fanquake ArisAthena maflcko

Labels
Build system

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me