fuzz: Fix test_runner error reporting #31489

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2412-fuzz-err changing 1 files +5 −5
  1. maflcko commented at 1:42 pm on December 13, 2024: member

    The error reporting is confusing, because right now it prints:

    https://cirrus-ci.com/task/4846031060336640?logs=ci#L4931

    0...
    1Traceback (most recent call last):
    2  File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 411, in <module>
    3    main()
    4  File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 199, in main
    5    run_once(
    6  File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 376, in run_once
    7    assert len(done_stat) == 1
    8           ^^^^^^^^^^^^^^^^^^^
    9AssertionError
    

    This is harmless, but confusing.

    Fix it by collecting statistics only when the program has not aborted. (Can be reviewed with --color-moved=dimmed-zebra)

    Also, reword the error message to align it with error messages in other test_runners in this repo.

  2. fuzz: Fix test_runner error reporting fa0e30b93a
  3. DrahtBot commented at 1:42 pm on December 13, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31489.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, brunoerg, marcofleon

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Dec 13, 2024
  5. dergoegge approved
  6. dergoegge commented at 2:17 pm on December 13, 2024: member
    utACK fa0e30b93aad29c17c173fab0ac9d339db6306d9
  7. brunoerg approved
  8. brunoerg commented at 12:45 pm on December 16, 2024: contributor
    code review ACK fa0e30b93aad29c17c173fab0ac9d339db6306d9
  9. marcofleon approved
  10. marcofleon commented at 2:02 pm on December 16, 2024: contributor
    Tested ACK fa0e30b93aad29c17c173fab0ac9d339db6306d9. Prints out the error for the target that crashed. Much clearer than the current error message.
  11. fanquake merged this on Dec 17, 2024
  12. fanquake closed this on Dec 17, 2024

  13. maflcko deleted the branch on Dec 18, 2024
  14. sedited referenced this in commit 230a439a4a on Jan 17, 2025
  15. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  16. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  17. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  18. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  19. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  20. bug-castercv502 referenced this in commit 44b075fe71 on Sep 28, 2025
  21. bitcoin locked this on Dec 18, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-31 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me