depends: Fix CXXFLAGS on NetBSD #31502

1. 
   hebasto commented at 8:38 pm on December 14, 2024: member

   This PR corrects an issue where CXXFLAGS were mistakenly overridden by CFLAGS. This behaviour was introduced in 7e7b3e42fa98b584ae60513a6774037bf677b8ce (from #22380).

   On the master branch:

   0$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
   1x86_64_netbsd_CXXFLAGS=-pipe -std=c11
   

   With this PR:

   0$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
   1x86_64_netbsd_CXXFLAGS=-pipe -std=c++20
   

2. depends: Fix CXXFLAGS on NetBSD

   This change corrects an issue where CXXFLAGS were mistakenly overridden
   by CFLAGS.

   a10bb400e8
3. hebasto added the label Build system on Dec 14, 2024
4. 
   DrahtBot commented at 8:38 pm on December 14, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31502.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. theuni approved
6. 
   theuni commented at 5:23 pm on December 16, 2024: member

   Whoops. Nice catch. Looks like this was the only one.

   utACK a10bb400e8cb0da0030114ee59f2e7c8494aef42

7. fanquake merged this on Dec 17, 2024
8. fanquake closed this on Dec 17, 2024

   ---

9. hebasto deleted the branch on Dec 17, 2024
10. fanquake added the label Needs backport (27.x) on Dec 17, 2024
11. fanquake added the label Needs backport (28.x) on Dec 17, 2024

Contributors
hebasto DrahtBot theuni

Labels
Build system Needs backport (27.x) Needs backport (28.x)