depends: Fix CXXFLAGS on NetBSD #31502

1. 
   hebasto commented at 8:38 pm on December 14, 2024: member

   This PR corrects an issue where CXXFLAGS were mistakenly overridden by CFLAGS. This behaviour was introduced in 7e7b3e42fa98b584ae60513a6774037bf677b8ce (from #22380).

   On the master branch:

   0$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
   1x86_64_netbsd_CXXFLAGS=-pipe -std=c11
   

   With this PR:

   0$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
   1x86_64_netbsd_CXXFLAGS=-pipe -std=c++20
   

2. depends: Fix CXXFLAGS on NetBSD

   This change corrects an issue where CXXFLAGS were mistakenly overridden
   by CFLAGS.

   a10bb400e8
3. hebasto added the label Build system on Dec 14, 2024
4. 
   DrahtBot commented at 8:38 pm on December 14, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31502.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. theuni approved
6. 
   theuni commented at 5:23 pm on December 16, 2024: member

   Whoops. Nice catch. Looks like this was the only one.

   utACK a10bb400e8cb0da0030114ee59f2e7c8494aef42

7. fanquake merged this on Dec 17, 2024
8. fanquake closed this on Dec 17, 2024

   ---

9. hebasto deleted the branch on Dec 17, 2024
10. fanquake added the label Needs backport (27.x) on Dec 17, 2024
11. fanquake added the label Needs backport (28.x) on Dec 17, 2024
12. maflcko removed the label Needs backport (28.x) on Jan 2, 2025
13. 
    maflcko commented at 1:28 pm on January 2, 2025: member

    28.x backport in https://github.com/bitcoin/bitcoin/pull/31594
14. fanquake removed the label Needs backport (27.x) on Jan 6, 2025
15. fanquake referenced this in commit c70bd786f8 on Jan 6, 2025
16. achow101 referenced this in commit 32efe85043 on Jan 7, 2025
17. TheCharlatan referenced this in commit 230a439a4a on Jan 17, 2025
18. fanquake referenced this in commit 1e7041a9f3 on Feb 11, 2025
19. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
20. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
21. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
22. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
23. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
24. 
    spboy777 commented at 12:19 pm on March 22, 2025: none

    F

Contributors
hebasto DrahtBot theuni maflcko spboy777

Labels
Build system