This PR corrects an issue where CXXFLAGS were mistakenly overridden by CFLAGS. This behaviour was introduced in 7e7b3e42fa98b584ae60513a6774037bf677b8ce (from #22380).
On the master branch:
$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
x86_64_netbsd_CXXFLAGS=-pipe -std=c11
With this PR:
$ gmake --no-print-directory -C depends print-x86_64_netbsd_CXXFLAGS
x86_64_netbsd_CXXFLAGS=-pipe -std=c++20
This change corrects an issue where CXXFLAGS were mistakenly overridden
by CFLAGS.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31502.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | theuni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Whoops. Nice catch. Looks like this was the only one.
utACK a10bb400e8cb0da0030114ee59f2e7c8494aef42
28.x backport in https://github.com/bitcoin/bitcoin/pull/31594
F