#31318 followups #31520

pull Sjors wants to merge 2 commits into bitcoin:master from Sjors:2024/12/pr-31318-followups changing 2 files +2 −2
  1. Sjors commented at 7:58 am on December 18, 2024: member

    #31318 followups

    Drops an extraneous bracket and fixes a typo.

  2. test: drop extraneous bracket in mining util 366fbf152c
  3. refactor: fix typo in node/types.h 4f06ae05ed
  4. DrahtBot commented at 7:58 am on December 18, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31520.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK vasild, maflcko, ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. vasild approved
  6. vasild commented at 8:14 am on December 18, 2024: contributor
    ACK 4f06ae05ed6f0dae44dfd62c37c048c2098e5ad3
  7. maflcko commented at 8:17 am on December 18, 2024: member
    lgtm ACK 4f06ae05ed6f0dae44dfd62c37c048c2098e5ad3
  8. ryanofsky approved
  9. ryanofsky commented at 7:38 pm on December 18, 2024: contributor
    Code review ACK 4f06ae05ed6f0dae44dfd62c37c048c2098e5ad3
  10. ryanofsky merged this on Dec 18, 2024
  11. ryanofsky closed this on Dec 18, 2024

  12. Sjors deleted the branch on Dec 19, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me