It is possible that someone accidentally removes the workaround in fa9e0489f57968945d54ef56b275f51540f3e5e4, or more likely that someone accidentally adds new code without the workaround.
Avoid this by adding a temporary CI check.
This can be tested by reverting the workaround and observing a failure.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31522.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Stale ACK | hebasto |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
For reference, this conflicts with commit a1add80c80bc95afdd55652bb87379fb34150a5c from
#29881 (guix: use GCC 13 to build releases by fanquake)
However, this is fine, because any version 12, or above should be fine. I’ve edited the pull title to clarify GCC-12+.
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/35781360834
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
https://cirrus-ci.com/task/5812783272427520?logs=ci#L4621:
0[15:22:49.280] [ 86%] Building CXX object src/test/fuzz/CMakeFiles/fuzz.dir/float.cpp.o
1[15:22:49.281] cd /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz && /usr/bin/ccache /opt/rh/gcc-toolset-12/root/usr/bin/g++ -m64 -DABORT_ON_FAILED_ASSUME -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DDEBUG -DDEBUG_LOCKCONTENTION -DDEBUG_LOCKORDER -DRPC_DOC_CHECK -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG -I/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src -I/ci_container_base/src -I/ci_container_base/src/univalue/include -I/ci_container_base/src/minisketch/include -I/ci_container_base/src/leveldb/include -I/ci_container_base/src/secp256k1/include -isystem /ci_container_base/depends/x86_64-pc-linux-gnu/include -pipe -std=c++20 -O0 -ftrapv -O1 -g3 -g3 -std=c++20 -fPIE -fvisibility=hidden -fno-extended-identifiers -fdebug-prefix-map=/ci_container_base/src=. -fmacro-prefix-map=/ci_container_base/src=. -fstack-reuse=none -Werror -Wall -Wextra -Wformat -Wformat-security -Wvla -Wredundant-decls -Wdate-time -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wbidi-chars=any -Wundef -Wno-unused-parameter -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -MD -MT src/test/fuzz/CMakeFiles/fuzz.dir/float.cpp.o -MF CMakeFiles/fuzz.dir/float.cpp.o.d -o CMakeFiles/fuzz.dir/float.cpp.o -c /ci_container_base/src/test/fuzz/float.cpp
2[15:22:51.900] In file included from /ci_container_base/src/test/fuzz/float.cpp:12:
3[15:22:51.900] In function ‘constexpr bool std::isnan(double)’,
4[15:22:51.900] inlined from ‘void float_fuzz_target(FuzzBufferType)’ at /ci_container_base/src/test/fuzz/float.cpp:58:9:
5[15:22:51.900] /opt/rh/gcc-toolset-12/root/usr/include/c++/12/cmath:620:27: error: ‘tmp’ may be used uninitialized [-Werror=maybe-uninitialized]
6[15:22:51.900] 620 | { return __builtin_isnan(__x); }
7[15:22:51.900] | ~~~~~~~~~~~~~~~^~~~~
8[15:22:51.900] /ci_container_base/src/test/fuzz/float.cpp: In function ‘void float_fuzz_target(FuzzBufferType)’:
9[15:22:51.900] /ci_container_base/src/test/fuzz/float.cpp:21:20: note: ‘tmp’ was declared here
10[15:22:51.900] 21 | double tmp;
11[15:22:51.900] | ^~~
12[15:22:51.900] cc1plus: all warnings being treated as errors
Guess it’s possible this is solved after #31593 (or not, if that doesn’t change compiler), so we could do that first.
This avoids an overly agressive GCC false positive warning:
error: ‘tmp’ may be used uninitialized [-Werror=maybe-uninitialized]