refactor: Allow std::byte in Read(LE/BE) #31524

1. 
   maflcko commented at 10:09 am on December 18, 2024: member

   Starting with C++17, std::byte is often (not always) a better choice over uint8_t for new code.

   However, the existing codebase discourages the use of std::byte, when helpers such as ReadLE32 are used. This is because calling code will be cluttered with byte-casts.

   Fix it by allowing std::byte pointers in ReadLE32 (and friends).

2. refactor: Allow std::byte in Read(LE/BE) fa83bec78e
3. 
   DrahtBot commented at 10:09 am on December 18, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31524.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa, theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Refactoring on Dec 18, 2024
5. 
   sipa commented at 3:51 pm on December 18, 2024: member

   utACK fa83bec78ef3e86445e522afa396c97b58eb1902
6. theuni approved
7. 
   theuni commented at 4:33 pm on December 18, 2024: member

   Nice use of concepts.

   utACK fa83bec78ef3e86445e522afa396c97b58eb1902

Contributors
maflcko DrahtBot sipa theuni

Labels
Refactoring