Enhance fee estimation logic and improve error handling in TxConfirmS… #31587

1. 
   Gudnessuche commented at 5:23 pm on December 31, 2024: none

   • Added reserve calls in TxConfirmStats constructor to avoid multiple reallocations for txCtAvg and m_feerate_avg vectors.
   • Added a check in resizeInMemoryCounters to ensure newbuckets is greater than 0, throwing an invalid_argument exception if not.
   • Improved error handling in Record method by adding a check to throw an out_of_range exception if blocksToConfirm exceeds the maximum tracked periods.
   • Fixed the missing parenthesis and completed the logic in the Read method to ensure proper sanity checks and resizing of in-memory counters.
   • These changes enhance the robustness and performance of the fee estimation logic in the Bitcoin Core codebase.
2. Enhance fee estimation logic and improve error handling in TxConfirmStats

   - Added reserve calls in TxConfirmStats constructor to avoid multiple reallocations for txCtAvg and m_feerate_avg vectors.
   - Added a check in resizeInMemoryCounters to ensure newbuckets is greater than 0, throwing an invalid_argument exception if not.
   - Improved error handling in Record method by adding a check to throw an out_of_range exception if blocksToConfirm exceeds the maximum tracked periods.
   - Fixed the missing parenthesis and completed the logic in the Read method to ensure proper sanity checks and resizing of in-memory counters.
   - These changes enhance the robustness and performance of the fee estimation logic in the Bitcoin Core codebase.

   305d45c3a6
3. 
   DrahtBot commented at 5:23 pm on December 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31587.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label CI failed on Dec 31, 2024
5. 
   DrahtBot commented at 5:25 pm on December 31, 2024: contributor

   🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/35022453454

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. maflcko closed this on Jan 1, 2025

   ---

Contributors
Gudnessuche DrahtBot

Labels
CI failed