contrib: fix test_deterministic_coverage.sh script for out-of-tree builds #31588

1. 
   theStack commented at 8:12 pm on January 1, 2025: contributor

   The determinstic line coverage checking script test_deterministic_coverage.sh was seemingly forgotten to be adapted in the course of switching from autotools to CMake (only the error messages containing build instructions were updated in a9964c04447745435747d9cc557165c43902783b / #30875). Since gcovr needs to access both the source and build files, the path to the latter has to be passed explicitly as they are not in the same anymore (see e.g. https://github.com/gcovr/gcovr/issues/340).

   Can be tested by:

   0$ cmake -B build -DCMAKE_BUILD_TYPE=Coverage
   1$ cmake --build build
   2$ ./contrib/devtools/test_deterministic_coverage.sh
   

   Alternatively, if the script is not needed anymore (apparently no-one else tried to execute it for the last three months?), it could also be deleted.

2. contrib: fix `test_deterministic_coverage.sh` script for out-of-tree builds e2404269ae
3. 
   DrahtBot commented at 8:13 pm on January 1, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31588.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Scripts and tools on Jan 1, 2025
5. in contrib/devtools/test_deterministic_coverage.sh:37 in e2404269ae

   33@@ -34,7 +34,7 @@ NON_DETERMINISTIC_TESTS=(
   34     "wallet_tests/wallet_disableprivkeys"                     # validation.cpp: if (signals.CallbacksPending() > 10)
   35 )
   36 
   37-TEST_BITCOIN_BINARY="src/test/test_bitcoin"
   38+TEST_BITCOIN_BINARY="build/src/test/test_bitcoin"
   

   ---

   ---

   

   maflcko commented at 1:35 pm on January 2, 2025:

   not sure about hardcoding. It would be better to have a symbol for this. This would also allow to remove mktemp and just use the build dir.

   ---

   

   theStack commented at 3:07 pm on January 2, 2025:

   Yeah, this is currently only a minimum-diff fix, happy to refine further. I assume with “symbol” you mean just another shell script variable, e.g. BUILD_DIR? (Could even go further and allow to specify the build-dir as an optional script parameter that defaults to “build”.)
6. fanquake added this to the milestone 29.0 on Jan 6, 2025

Contributors
theStack DrahtBot maflcko

Labels
Scripts and tools

Milestone
29.0