[28.x] 28.1 backports and final changes #31594

1. 
   maflcko commented at 1:26 pm on January 2, 2025: member

   Backports:

   • #31502
   • #31563
2. rpc: Extend scope of validation mutex in generateblock

   The mutex (required by TestBlockValidity) must be held after creating
   the block, until TestBlockValidity is called. Otherwise, it is possible
   that the chain advances in the meantime and leads to a crash in
   TestBlockValidity:
   
    Assertion failed: pindexPrev && pindexPrev == chainstate.m_chain.Tip() (validation.cpp: TestBlockValidity: 4338)
   
   The diff can be reviewed with the git options
   --ignore-all-space --function-context
   
   Github-Pull: 31563
   Rebased-From: fa62c8b1f04a5386ffa171aeff713d55bd874cbe

   621c634b7f
3. test: generateblocks called by multiple threads

   Co-Authored-By: David Gumberg <davidzgumberg@gmail.com>
   
   Github-Pull: 31563
   Rebased-From: fa63b8232f38e78d3c6413fa7d51809f376de75c

   05cd448e33
4. depends: Fix CXXFLAGS on NetBSD

   This change corrects an issue where CXXFLAGS were mistakenly overridden
   by CFLAGS.
   
   Github-Pull: 31502
   Rebased-From: a10bb400e8cb0da0030114ee59f2e7c8494aef42

   5b368f88a9
5. 
   DrahtBot commented at 1:26 pm on January 2, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31594.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. DrahtBot added the label Backport on Jan 2, 2025
7. maflcko renamed this:
   28.1rc3 backports
   [28.x] 28.1rc3 backports
   on Jan 2, 2025
8. 
   achow101 commented at 6:45 pm on January 2, 2025: member

   Are these significant enough to warrant a rc3 or can we go straight to final?
9. build: bump to 28.1 6a68ef9bfb
10. doc: generate 28.1 manpages 58910279dc
11. maflcko force-pushed on Jan 2, 2025
12. maflcko renamed this:
    [28.x] 28.1rc3 backports
    [28.x] 28.1 backports
    on Jan 2, 2025
13. maflcko renamed this:
    [28.x] 28.1 backports
    [28.x] 28.1 backports (final?)
    on Jan 2, 2025
14. 
    maflcko commented at 7:57 pm on January 2, 2025: member

    Are these significant enough to warrant a rc3 or can we go straight to final?

    Yes, seems fine in this special case, as the depends patch shouldn’t affect the release bin and the other change is test-only. I went ahead and picked your commits from https://github.com/bitcoin/bitcoin/pull/31582

15. 
    achow101 commented at 4:54 pm on January 3, 2025: member

    ACK 1451c56cce3e3df784e1dac969ffb0165df313c7
16. in doc/release-notes.md:71 in 1451c56cce outdated

    67@@ -68,12 +68,14 @@ Notable changes
    68 ### Build
    69 
    70 - #31013 depends: For mingw cross compile use `-gcc-posix` to prevent library conflict
    71+- #31502 depends: Fix CXXFLAGS on NetBSD
    

    ---

    ---

    

    glozow commented at 6:41 pm on January 3, 2025:

    Should also add hebasto to the credits

    ---

    

    maflcko commented at 10:06 am on January 6, 2025:

    Good catch. Added missing credit line!
17. 
    glozow commented at 6:42 pm on January 3, 2025: member

    ACK 1451c56cce3e3df784e1dac969ffb0165df313c7 except for release note
18. glozow renamed this:
    [28.x] 28.1 backports (final?)
    [28.x] 28.1 backports and final changes
    on Jan 3, 2025
19. 
    laanwj commented at 9:57 pm on January 3, 2025: member

    Are these significant enough to warrant a rc3 or can we go straight to final?

    The only change here that could trigger a new RC is the change in src/rpc/mining.cpp, which affects the release binary, but as that’s contained to a test-only RPC i don’t think it’s worth rolling another rc for. The rest are test changes (and build system for an OS that’s only tangentially supported).

20. 
    Sjors commented at 1:53 pm on January 4, 2025: member

    In light of #31600 (comment) it may be worth back-porting that PR as well. On the other hand it only impacts testnet4.
21. doc: Update 28.1 release notes 36314b8da2
22. maflcko force-pushed on Jan 6, 2025
23. 
    maflcko commented at 10:05 am on January 6, 2025: member

    @Sjors I don’t think it is useful to backport PRs which have neither been reviewed, nor merged into a final tag without a rc even. Especially, given that the fix is for test-only network with brittle mining anyway.
24. 
    Sjors commented at 10:12 am on January 6, 2025: member

    @maflcko obviously I’m not advocating backporting the PR before it’s merged, but rather to delay the release until it is.

    Especially, given that the fix is for test-only network with brittle mining anyway.

    That’s probably a good reason to not wait, but it seemed good to bring it up.

25. 
    glozow commented at 12:31 pm on January 6, 2025: member

    reACK 36314b8da2ee65afd5636fa830d436c5c22bd260
26. DrahtBot requested review from achow101 on Jan 6, 2025
27. 
    achow101 commented at 6:17 pm on January 7, 2025: member

    ACK 36314b8da2ee65afd5636fa830d436c5c22bd260
28. achow101 merged this on Jan 7, 2025
29. achow101 closed this on Jan 7, 2025

    ---

30. maflcko deleted the branch on Jan 7, 2025
31. 
    Missjones2829 commented at 1:15 pm on January 15, 2025: none

    Merge

Contributors
maflcko DrahtBot achow101 glozow laanwj Sjors Missjones2829

Review Requested
achow101

Labels
Backport