doc: Clarify min macOS and Xcode version #31608

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2501-doc-macos changing 2 files +6 −2
  1. maflcko commented at 9:09 am on January 6, 2025: member

    Two minor doc fixups:

    • Clarify that macOS 13.0+ means macOS 13+, indicating that on any major version, only the latest security release is supported.
    • Clarify that the Xcode version was selected based on the minimum required macOS version and the minimum required clang version.
  2. DrahtBot commented at 9:09 am on January 6, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31608.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK jarolrod, hebasto, theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Jan 6, 2025
  4. maflcko force-pushed on Jan 6, 2025
  5. in doc/release-notes-empty-template.md:46 in fa728e4f18 outdated
    42@@ -43,7 +43,7 @@ Compatibility
    43 ==============
    44 
    45 Bitcoin Core is supported and tested on operating systems using the
    46-Linux Kernel 3.17+, macOS 13.0+, and Windows 10 and newer. Bitcoin
    47+Linux Kernel 3.17+, macOS 13+, and Windows 10 and newer. Bitcoin
    


    hebasto commented at 11:12 am on January 6, 2025:
    nit: While touching this line, we can use “+” or “and newer” consistently without mixing both.
  6. hebasto approved
  7. hebasto commented at 11:12 am on January 6, 2025: member
    ACK fa728e4f184ebbbcab07047cd8790fb9b16d5681.
  8. in .github/workflows/ci.yml:115 in fa728e4f18 outdated
    110@@ -111,6 +111,10 @@ jobs:
    111 
    112       - name: Clang version
    113         run: |
    114+          # Use the earliest Xcode supported by the version of macOS denoted in
    115+          # doc/release-notes-empty-template.md and providing the at least the
    


    fanquake commented at 11:17 am on January 6, 2025:
    typo: providing the at least the
  9. fanquake commented at 11:19 am on January 6, 2025: member

    only the latest security release is supported.

    Should this change OSX_MIN_VERSION? Otherwise we are just changing the docs to no-longer reflect the compatibility of the binary we ship (it will still run on any 13.x).

  10. maflcko commented at 11:27 am on January 6, 2025: member

    only the latest security release is supported.

    Should this change OSX_MIN_VERSION? Otherwise we are just changing the docs to no-longer reflect the compatibility of the binary we ship (it will still run on any 13.x).

    While I think that only the latest minor security release is supported, it may be a bit too much handholding and churn to bump OSX_MIN_VERSION on every new macOS minor release. In reality it will take time to get into a release and until users upgrade, so I wonder if micro-managing OSX_MIN_VERSION even matters in practise. Does macOS auto-update or provide pop-ups for minor releases? Maybe a separate issue or pull request could be considered, as this one is mostly about the min xcode version when compiling from source, not about the pre-compiled release bins or the depends build.

  11. doc: Clarify min macOS and Xcode version fa029a7878
  12. maflcko force-pushed on Jan 6, 2025
  13. jarolrod commented at 3:17 pm on January 6, 2025: member

    ACK fa029a78780fd00e1d3ce1bebb81a95857bfbb94

    Does macOS auto-update or provide pop-ups for minor releases?

    Yeah, depending on the users preference for auto-updates. See “Automatic Updates”

  14. DrahtBot requested review from hebasto on Jan 6, 2025
  15. hebasto approved
  16. hebasto commented at 5:08 pm on January 7, 2025: member
    re-ACK fa029a78780fd00e1d3ce1bebb81a95857bfbb94.
  17. theuni approved
  18. theuni commented at 5:45 pm on January 8, 2025: member
    ACK fa029a78780fd00e1d3ce1bebb81a95857bfbb94
  19. maflcko requested review from fanquake on Jan 9, 2025
  20. fanquake merged this on Jan 10, 2025
  21. fanquake closed this on Jan 10, 2025

  22. maflcko deleted the branch on Jan 10, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me