The line has been present since the beginning.
Removed redundant duration as well since it can be recovered from the timestamps.
Example logs before the change:
02025-01-07T11:58:33Z Verification progress: 99%
12025-01-07T11:58:33Z Verification: No coin database inconsistencies in last 6 blocks (18905 transactions)
22025-01-07T11:58:33Z block index 31892ms
32025-01-07T11:58:33Z Setting NODE_NETWORK on non-prune mode
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31616.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, TheCharlatan, danielabrozzoni, BrandonOdiwuor |
| Stale ACK | theuni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
1262@@ -1263,7 +1263,7 @@ static ChainstateLoadResult InitAndLoadChainstate(
1263 }
1264 std::tie(status, error) = catch_exceptions([&] { return VerifyLoadedChainstate(chainman, options); });
1265 if (status == node::ChainstateLoadStatus::SUCCESS) {
1266- LogPrintf(" block index %15dms\n", Ticks<std::chrono::milliseconds>(SteadyClock::now() - load_block_index_start_time));
1267+ LogInfo("Block index %15dms\n", Ticks<std::chrono::milliseconds>(SteadyClock::now() - load_block_index_start_time));
"Loading block index..." are just kind of bad to be honest. We are definitely doing more here than loading the block index. I’m not even sure if the measured time here provides anything useful given that it varies quite a bit form run to run and we already log timestamps by default. Maybe this should rather just say "Loaded block index and chainstate"?
Example logs before the change:
```
2025-01-07T11:58:33Z Verification progress: 99%
2025-01-07T11:58:33Z Verification: No coin database inconsistencies in last 6 blocks (18905 transactions)
2025-01-07T11:58:33Z block index 31892ms
2025-01-07T11:58:33Z Setting NODE_NETWORK on non-prune mode
2025-01-07T11:58:33Z block tree size = 878086
2025-01-07T11:58:33Z nBestHeight = 878085
```
Removed redundant duration as well since it can be recovered from the timestamps.
Co-authored-by: TheCharlatan <seb.kung@gmail.com>
Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
