This is similar to the recently-pushed 8d20348 and results in slightly cleaner systems for future Debian/Ubuntu builds.
According to the description for pkg-config, “pkgconf is a replacement for pkg-config, providing additional functionality while also maintaining compatibility. This package only provides a dependency link to the pkgconf package to help with package upgrades. It can be safely removed.”
Thus the relevant sections of doc/build-unix.md and depends/README.md are updated.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31621.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Jammy and Bullseye don’t provide the alias/redirect from pkg-config to pkgconf, but I guess their version of pkgconf should be good enough? Otherwise, it may be better to wait until they are unsupported.
If this change is made, depends/README.md should be updated as well. Same for ci/test/00_setup_env.sh and .github/workflows/ci.yml.
Jammy and Bullseye don’t provide the alias/redirect from pkg-config to pkgconf, but I guess their version of pkgconf should be good enough? Otherwise, it may be better to wait until they are unsupported.
The Debian package for pkg-config is still there, and depends on pkgconf… if only it were as lightweight as merely aliasing.
If this change is made,
depends/README.mdshould be updated as well. Same forci/test/00_setup_env.shand.github/workflows/ci.yml.
Thank you for highlighting the specific locations; I believe one was already fixed in #31335 although I’ve not read the entire conversation there yet; commit fe3457c does touch the CI.yml although it only removes pkg-config without including pkgconf! The blessed Arch Linux coda in docs/build-unix.md doesn’t include either one, either…
If this change is made,
depends/README.mdshould be updated as well. Same forci/test/00_setup_env.shand.github/workflows/ci.yml.
I have force-pushed to include updates to those two files, along with a few more places; there are still several results to git grep pkg-config: mostly from old release notes, which should probably be left untouched; a few from other distros, where I’ve not tested things; and a few invocations of pkg-config which should work with either version, so I’ve not updated these because it could break systems that have not yet updated.
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/35722632071
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
along with a few more places
You can’t change the others, as they are fixed subtrees. (See the CI failure).
The automated checks are now reporting two instances of:
0FAIL: subtree directory was touched without subtree merge
from the places were I fixed a typo in a comment. I’m not familiar with this specific linter setup, and this isn’t supposed to be a merge commit, so could someone please point me towards some documentation or just explain directly why this check fails?
According to the description for pkg-config, "pkgconf is a
replacement for pkg-config, providing additional functionality
while also maintaining compatibility. This package only provides
a dependency link to the pkgconf package to help with package
upgrades. It can be safely removed."
Thus several scripts and markdown files are updated.
along with a few more places
You can’t change the others, as they are fixed subtrees. (See the CI failure).
I force-pushed again to remove the modifications to the two Dockerfile scripts.
weak ACK 160c27ec078346fbf07f9b84dc10cef2b9809327
The code changes look fine, and the passing CI seems to indicate that pkgconf works even on Jammy and Bullseye. However, I haven’t spend much time looking into the background here.
