tracing: Rename the MIN macro to _TRACEPOINT_TEST_MIN in log_raw_p2p_msgs #31623

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:tracing_MIN_macro_rename changing 1 files +4 −3
  1. luke-jr commented at 6:44 am on January 9, 2025: member

    Inspired by: 00c1dbd26ddb816e5541c5724397015a92a3d06b (#31419)

    Unless there’s a reason we don’t want the same change here…?

  2. tracing: Rename the `MIN` macro to `_TRACEPOINT_TEST_MIN` in log_raw_p2p_msgs
    Inspired by: 00c1dbd26ddb816e5541c5724397015a92a3d06b (#31419)
    f93f0c9396
  3. DrahtBot commented at 6:44 am on January 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31623.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, 0xB10C

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 11:40 am on January 9, 2025: member

    I did not test with #31418, but the change would be harmless in the worst case anyway.

    review ACK f93f0c93961bbce413101c2a92300a7a29277506 🔶

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: review ACK f93f0c93961bbce413101c2a92300a7a29277506 🔶
    3hNaav1bocAYFgaN1U5D5+b3r088QmK9iFxhcykDq5QQ3YRpWaUqQm/JvwQAWUu5LbTrGv6orFTs5UD3kkR77Ag==
    
  5. 0xB10C commented at 10:38 am on January 10, 2025: contributor

    tested ACK f93f0c93961bbce413101c2a92300a7a29277506

    I did check that the contrib/tracing/log_raw_p2p_msgs.py script still works for me, but did not test on Rawhide.

    Thanks for picking this up.

  6. fanquake merged this on Jan 10, 2025
  7. fanquake closed this on Jan 10, 2025

  8. fanquake referenced this in commit 8588d5bbe0 on Jan 10, 2025
  9. fanquake referenced this in commit 2829588882 on Jan 13, 2025
  10. sedited referenced this in commit 230a439a4a on Jan 17, 2025
  11. fanquake referenced this in commit 1e7041a9f3 on Feb 11, 2025
  12. glozow referenced this in commit dbc450c1b5 on Mar 5, 2025
  13. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  14. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  15. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  16. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  17. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  18. bug-castercv502 referenced this in commit 44b075fe71 on Sep 28, 2025
  19. knst referenced this in commit da9c13e93e on Oct 22, 2025
  20. bitcoin locked this on Jan 10, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-10 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me