Inspired by: 00c1dbd26ddb816e5541c5724397015a92a3d06b (#31419)
Unless there's a reason we don't want the same change here...?
tracing: Rename the `MIN` macro to `_TRACEPOINT_TEST_MIN` in log_raw_p2p_msgs #31623
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:tracing_MIN_macro_rename changing 1 files +4 −3-
luke-jr commented at 6:44 AM on January 9, 2025: member
-
f93f0c9396
tracing: Rename the `MIN` macro to `_TRACEPOINT_TEST_MIN` in log_raw_p2p_msgs
Inspired by: 00c1dbd26ddb816e5541c5724397015a92a3d06b (#31419)
-
DrahtBot commented at 6:44 AM on January 9, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31623.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 11:40 AM on January 9, 2025: member
I did not test with #31418, but the change would be harmless in the worst case anyway.
review ACK f93f0c93961bbce413101c2a92300a7a29277506 🔶
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}" RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM= trusted comment: review ACK f93f0c93961bbce413101c2a92300a7a29277506 🔶 hNaav1bocAYFgaN1U5D5+b3r088QmK9iFxhcykDq5QQ3YRpWaUqQm/JvwQAWUu5LbTrGv6orFTs5UD3kkR77Ag==</details>
-
0xB10C commented at 10:38 AM on January 10, 2025: contributor
tested ACK f93f0c93961bbce413101c2a92300a7a29277506
I did check that the
contrib/tracing/log_raw_p2p_msgs.pyscript still works for me, but did not test on Rawhide.Thanks for picking this up.
- fanquake merged this on Jan 10, 2025
- fanquake closed this on Jan 10, 2025
- fanquake referenced this in commit 8588d5bbe0 on Jan 10, 2025
- fanquake referenced this in commit 2829588882 on Jan 13, 2025
- sedited referenced this in commit 230a439a4a on Jan 17, 2025
- fanquake referenced this in commit 1e7041a9f3 on Feb 11, 2025
- glozow referenced this in commit dbc450c1b5 on Mar 5, 2025
- stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
- stickies-v referenced this in commit cc83553352 on Mar 17, 2025
- stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
- stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
- stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
- bug-castercv502 referenced this in commit 44b075fe71 on Sep 28, 2025
- knst referenced this in commit da9c13e93e on Oct 22, 2025
- bitcoin locked this on Jan 10, 2026
