fix: Optimized Performance Update bloom.cpp #31632

pull barajeel wants to merge 1 commits into bitcoin:master from barajeel:patch-1 changing 1 files +25 −50
  1. barajeel commented at 7:56 am on January 10, 2025: none

    I made several optimizations to the Bloom filter code to enhance its performance and readability:

    • Removed redundant calculations by precomputing frequently used values.
    • Added early exits in loops to avoid unnecessary iterations.
    • Retained efficient bitwise operations for setting and checking bits.
    • Improved memory resizing for the CRollingBloomFilter by using bit shifts.
    • Simplified conditionals in the IsRelevantAndUpdate method for better clarity.
    • Improved comments to better explain the logic.
  2. fix: Optimized Performance Update bloom.cpp 676400b05f
  3. DrahtBot commented at 7:56 am on January 10, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31632.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label CI failed on Jan 10, 2025
  5. DrahtBot commented at 7:59 am on January 10, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/35416652334

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  6. maflcko closed this on Jan 10, 2025

  7. barajeel deleted the branch on Jan 10, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-18 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me