Show sighash flags #3166

1. 
   gmaxwell commented at 10:30 am on October 27, 2013: contributor

   We should be showing sighash flags on signatures in transaction decodes.
2. 
   jgarzik commented at 2:32 pm on October 27, 2013: contributor

   +1
3. 
   laanwj commented at 3:43 pm on November 11, 2013: member

   To be clear: the sighash flags are the nHashType byte (enumeration SIGHASH_*), which is stored in the last byte of vchSig?

   As this value is pushed to the stack in a prior op, this would require a non-trivial change to transaction decodes (which I suppose means those in Script::ToString https://github.com/bitcoin/bitcoin/blob/master/src/script.h#L580) that ‘reasons backwards’? Or do I miss something?

4. 
   ExperimentsAndIdeas commented at 6:00 pm on March 3, 2014: none

   +1 to fix the missing SIGHASH in JSON output… I would like this feature.
5. mruddy referenced this in commit 1f028d64b0 on Nov 12, 2014
6. mruddy referenced this in commit 41af24109f on Nov 12, 2014
7. mruddy referenced this in commit 726a28043b on Nov 28, 2014
8. mruddy referenced this in commit bfbe34bedc on Nov 28, 2014
9. mruddy referenced this in commit 628bbfcd94 on Nov 28, 2014
10. mruddy referenced this in commit d43219b134 on Dec 12, 2014
11. mruddy referenced this in commit 4ff5162f19 on Dec 13, 2014
12. mruddy referenced this in commit c7f8c0a4d1 on Dec 20, 2014
13. mruddy referenced this in commit 8ec43dce4e on Dec 20, 2014
14. mruddy referenced this in commit afd920e8be on Dec 21, 2014
15. laanwj closed this on Sep 25, 2015

    ---

16. str4d referenced this in commit 690d38f0f8 on Apr 17, 2018
17. Bushstar referenced this in commit dfd6ee472a on Apr 8, 2020
18. Bushstar referenced this in commit ce66871308 on Apr 8, 2020
19. random-zebra referenced this in commit 26b9de4eea on May 20, 2020
20. random-zebra referenced this in commit 3383983ec6 on May 27, 2020
21. furszy referenced this in commit 8cd9c592a9 on May 29, 2020
22. DrahtBot locked this on Sep 8, 2021

Contributors
gmaxwell jgarzik laanwj ExperimentsAndIdeas

Labels
Refactoring