We should be showing sighash flags on signatures in transaction decodes.
-
gmaxwell commented at 10:30 AM on October 27, 2013: contributor
-
jgarzik commented at 2:32 PM on October 27, 2013: contributor
+1
-
laanwj commented at 3:43 PM on November 11, 2013: member
To be clear: the sighash flags are the
nHashTypebyte (enumeration SIGHASH_*), which is stored in the last byte of vchSig?As this value is pushed to the stack in a prior op, this would require a non-trivial change to transaction decodes (which I suppose means those in Script::ToString https://github.com/bitcoin/bitcoin/blob/master/src/script.h#L580) that 'reasons backwards'? Or do I miss something?
-
ExperimentsAndIdeas commented at 6:00 PM on March 3, 2014: none
+1 to fix the missing SIGHASH in JSON output... I would like this feature.
- mruddy referenced this in commit 1f028d64b0 on Nov 12, 2014
- mruddy referenced this in commit 41af24109f on Nov 12, 2014
- mruddy referenced this in commit 726a28043b on Nov 28, 2014
- mruddy referenced this in commit bfbe34bedc on Nov 28, 2014
- mruddy referenced this in commit 628bbfcd94 on Nov 28, 2014
- mruddy referenced this in commit d43219b134 on Dec 12, 2014
- mruddy referenced this in commit 4ff5162f19 on Dec 13, 2014
- mruddy referenced this in commit c7f8c0a4d1 on Dec 20, 2014
- mruddy referenced this in commit 8ec43dce4e on Dec 20, 2014
- mruddy referenced this in commit afd920e8be on Dec 21, 2014
- laanwj closed this on Sep 25, 2015
- str4d referenced this in commit 690d38f0f8 on Apr 17, 2018
- Bushstar referenced this in commit dfd6ee472a on Apr 8, 2020
- Bushstar referenced this in commit ce66871308 on Apr 8, 2020
- random-zebra referenced this in commit 26b9de4eea on May 20, 2020
- random-zebra referenced this in commit 3383983ec6 on May 27, 2020
- furszy referenced this in commit 8cd9c592a9 on May 29, 2020
- DrahtBot locked this on Sep 8, 2021