depends: Override default build type for `libevent`

hebasto commented at 9:28 am on January 15, 2025: member

This PR fixes a regression for the libevent package introduced in #29835.

The libevent package defaults to the “Release” build type, which overrides our per-build-type optimization flags with -O3.

To prevent this behavior, set CMAKE_BUILD_TYPE to “None”, consistent with how other packages are handled.

hebasto added the label Build system on Jan 15, 2025

DrahtBot commented at 9:28 am on January 15, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31661.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto added this to the milestone 29.0 on Jan 15, 2025

hebasto removed this from the milestone 29.0 on Jan 15, 2025

hebasto added this to the milestone 28.2 on Jan 15, 2025

hebasto removed this from the milestone 28.2 on Jan 15, 2025

hebasto added this to the milestone 29.0 on Jan 15, 2025

hebasto commented at 11:51 am on January 15, 2025: member

My Guix build:

 0aarch64
 186fcefb01cf8fb3d3bfc0639b270f4df96567066620cdaf9d1a3fc70664c1755  guix-build-dd7868a173fb/output/aarch64-linux-gnu/SHA256SUMS.part
 2ebca518cd64e7f45d96a758ed8d06c3a2689aa1783f75366e3a5f4a32fd79bca  guix-build-dd7868a173fb/output/aarch64-linux-gnu/bitcoin-dd7868a173fb-aarch64-linux-gnu-debug.tar.gz
 3b93ef69b68418482fab8977b5a590fbacd4aa37ae5d8f1da1cc5b071df9b6c17  guix-build-dd7868a173fb/output/aarch64-linux-gnu/bitcoin-dd7868a173fb-aarch64-linux-gnu.tar.gz
 462f77252880738db554f7977e4f444cf28f9a71d2a3e0055e1efebc5fca65816  guix-build-dd7868a173fb/output/arm-linux-gnueabihf/SHA256SUMS.part
 507a7bc7813d9fb0f3cf881081059ca02f744e172c6c9c9f5bdd5254a610e70b5  guix-build-dd7868a173fb/output/arm-linux-gnueabihf/bitcoin-dd7868a173fb-arm-linux-gnueabihf-debug.tar.gz
 64e5f7b781379e5decbb61192b7862eb94736b0af02fcd4ce00b2c4709a74ddc5  guix-build-dd7868a173fb/output/arm-linux-gnueabihf/bitcoin-dd7868a173fb-arm-linux-gnueabihf.tar.gz
 75b61db8f0ba10d57bf1f2474d5b5a36f5b3fe95c74d57a3912deb2603361a728  guix-build-dd7868a173fb/output/arm64-apple-darwin/SHA256SUMS.part
 818a51ddf6355c85cb90e9acafd226317c72e7b2fe6192c81661b74f5408dde2a  guix-build-dd7868a173fb/output/arm64-apple-darwin/bitcoin-dd7868a173fb-arm64-apple-darwin-unsigned.tar.gz
 9cf0758ab71fe90d7ba71f48f2513339cf7564cd5739f37eebf9b4f2af90d2063  guix-build-dd7868a173fb/output/arm64-apple-darwin/bitcoin-dd7868a173fb-arm64-apple-darwin-unsigned.zip
10e37bb992236de3b84eaad91c6ddda6aa6dc07639880615074cd22124534a8da6  guix-build-dd7868a173fb/output/arm64-apple-darwin/bitcoin-dd7868a173fb-arm64-apple-darwin.tar.gz
117aa97c05988b8ef8d52d2564c2a0a44e612f60aeb2112743dee27bc0dddb3506  guix-build-dd7868a173fb/output/dist-archive/bitcoin-dd7868a173fb.tar.gz
12cdbc38e6fe5a92f25085ab8102e4e89ec5b176e0022685ee5f68f386de231adb  guix-build-dd7868a173fb/output/powerpc64-linux-gnu/SHA256SUMS.part
13b524a5d6fd5a55c036e70b7d6c61c6d880cfe6aab5ed41e14064a57ce9a1b4de  guix-build-dd7868a173fb/output/powerpc64-linux-gnu/bitcoin-dd7868a173fb-powerpc64-linux-gnu-debug.tar.gz
1416e96e5e3b314fb63638db2ade0039c73df53cf74dc09918434cc6d96dc38334  guix-build-dd7868a173fb/output/powerpc64-linux-gnu/bitcoin-dd7868a173fb-powerpc64-linux-gnu.tar.gz
15f10b60add22f1680c52de6a920486c7f742010a66fb224586ce4fe6550064fb2  guix-build-dd7868a173fb/output/riscv64-linux-gnu/SHA256SUMS.part
16c6cc34f9b81e134e5b4707d89983238ce25c88248e890193c97899a95c741448  guix-build-dd7868a173fb/output/riscv64-linux-gnu/bitcoin-dd7868a173fb-riscv64-linux-gnu-debug.tar.gz
17f1d5d2fad90a3e6eeb47fd094671c59be290ab414ab79623f456596724d1e949  guix-build-dd7868a173fb/output/riscv64-linux-gnu/bitcoin-dd7868a173fb-riscv64-linux-gnu.tar.gz
187077ed544d94572889afde0bc29bb035010b1a8a5eb3c4c09c9cf8225227610b  guix-build-dd7868a173fb/output/x86_64-apple-darwin/SHA256SUMS.part
190c2d359c91089927ae758e00b1b9ddc59ef897e2ff86c3dbb7ede8ec5379805b  guix-build-dd7868a173fb/output/x86_64-apple-darwin/bitcoin-dd7868a173fb-x86_64-apple-darwin-unsigned.tar.gz
20dc57e5974dced23a30ade9a4f98fe33d1d31120f314fff691ee2676473d5cde8  guix-build-dd7868a173fb/output/x86_64-apple-darwin/bitcoin-dd7868a173fb-x86_64-apple-darwin-unsigned.zip
21bd625e3808707f92f8e6977fefd263b289cfe72b9bd973e8b08eae9d64ec7774  guix-build-dd7868a173fb/output/x86_64-apple-darwin/bitcoin-dd7868a173fb-x86_64-apple-darwin.tar.gz
222080821630d89152a1a583a4f87c6d605ebda367eab7691963dfd9af2c67b372  guix-build-dd7868a173fb/output/x86_64-linux-gnu/SHA256SUMS.part
23a4f783b61322c260dc2770d4dbc1033f622f5ca8ffd21c7ca82fa5ca359b713d  guix-build-dd7868a173fb/output/x86_64-linux-gnu/bitcoin-dd7868a173fb-x86_64-linux-gnu-debug.tar.gz
2468f1f9f17e14ea3e3486a13e6282d12e399ee58d4556e3d9e512863d3f777bce  guix-build-dd7868a173fb/output/x86_64-linux-gnu/bitcoin-dd7868a173fb-x86_64-linux-gnu.tar.gz
25e11b5fc3884d7552b9b54fade3b5e17926b47e10818012adc1de420585fbcb29  guix-build-dd7868a173fb/output/x86_64-w64-mingw32/SHA256SUMS.part
26c8cd6e79b311eb71b4ef334c3a0c9fb3823bded3047ee53b21177babc9eb36aa  guix-build-dd7868a173fb/output/x86_64-w64-mingw32/bitcoin-dd7868a173fb-win64-debug.zip
27174a3d0863e32ec1f5bfb40d63c2ed29e49d1ee4d6714dda90f33badcbd67951  guix-build-dd7868a173fb/output/x86_64-w64-mingw32/bitcoin-dd7868a173fb-win64-setup-unsigned.exe
284441e572ede42a909338f69669f9d8c4adb16a59d1c05e14ed60f4b0d33f6bc4  guix-build-dd7868a173fb/output/x86_64-w64-mingw32/bitcoin-dd7868a173fb-win64-unsigned.tar.gz
29d256b7e9d625664d3b274b74a02eff10a084477c246a52f19a42f24590b936d5  guix-build-dd7868a173fb/output/x86_64-w64-mingw32/bitcoin-dd7868a173fb-win64.zip

thomasplantin approved

theuni commented at 8:22 pm on January 17, 2025: member

For packages that do not set a default build type, this change does not affect their behaviour.

Are you sure this is true? It definitely could affect behavior. I’m wondering if we should do it per-package, even if it’s every package, as a sign-off that we’ve actually checked that it does the right thing.

depends: Override default build type for `libevent`

The `libevent` package defaults to the "Release" build type, which
overrides our per-build-type optimization flags with `-O3`.

To prevent this behavior, set `CMAKE_BUILD_TYPE` to "None", consistent
with how other packages are handled.

d7d3bb1bbc

hebasto force-pushed on Jan 20, 2025

hebasto commented at 9:58 am on January 20, 2025: member

For packages that do not set a default build type, this change does not affect their behaviour.

Are you sure this is true? It definitely could affect behavior. I’m wondering if we should do it per-package, even if it’s every package, as a sign-off that we’ve actually checked that it does the right thing.

Reworked.

hebasto renamed this:
~~depends: Always set `CMAKE_BUILD_TYPE=None` globally~~
depends: Override default build type for `libevent`
on Jan 20, 2025

hebasto commented at 11:52 am on January 20, 2025: member

My Guix build:

 0aarch64
 19642c7c336c6dda11fd7f0e085910ab9f4edf73d41401a6df333f7ac979fd845  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/SHA256SUMS.part
 2f5f224be7a011f1465f995bb21a9f3af18567911272d795a937913370012d83f  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/bitcoin-d7d3bb1bbcc0-aarch64-linux-gnu-debug.tar.gz
 37cd81a1879b84a00a9a623f056f8f06127377cedd87220d577a32a81beda79de  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/bitcoin-d7d3bb1bbcc0-aarch64-linux-gnu.tar.gz
 41d75c0d8ea2b82580a82b03879de60adcdfdea796b97fa5dbd16ddfcbf6b5b30  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/SHA256SUMS.part
 55596badf7fc9fd750ad1bd136e0c5d64e008fcc11b57c42f1644102e9b8e85e7  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/bitcoin-d7d3bb1bbcc0-arm-linux-gnueabihf-debug.tar.gz
 6b446426ac00ceb737ab62f5cd807f43f0e15efeb3f0ac36faede49d3f6870890  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/bitcoin-d7d3bb1bbcc0-arm-linux-gnueabihf.tar.gz
 71ec9474c4d4ba7b8e09a6ee61b9cb11b76c12cee2d164dbaf6586563212ec7ac  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/SHA256SUMS.part
 8bab59243ae46d748397f9aadea84a2673381527d4f7d57b37de99467f7d93378  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin-unsigned.tar.gz
 99b926a7e3bcd43c363d42489a0dba92e1b54e7fe015c312de2308a4236e4dd0c  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin-unsigned.zip
10224ba4173858a7140fa8b96ab4904f8f746091d8cdef40c1d68ff37fc6abb2fb  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin.tar.gz
11500751e3817551bbdb1377b7947bb666a34d018a018f01b5e4b035e221950f7c  guix-build-d7d3bb1bbcc0/output/dist-archive/bitcoin-d7d3bb1bbcc0.tar.gz
1263e08c1f38f893b7b928ee707f8206782c800cc25cf84146f42c9f92c39f43bb  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/SHA256SUMS.part
138d6efeb86bad556ee510ddf3c0fac0c15cb257e884a057dd5f51c92dd4689653  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/bitcoin-d7d3bb1bbcc0-powerpc64-linux-gnu-debug.tar.gz
14b9c1e9816e0399b5960b0a7f1ed547ae82c839c6d9dc4ec78ffc661e5f4f3db5  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/bitcoin-d7d3bb1bbcc0-powerpc64-linux-gnu.tar.gz
15d09c2c663f856cabbad0259fe200cd6091cc3546647ec77f5517b34bcb9d4429  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/SHA256SUMS.part
160de69c2c507243f2e0da67092e192edf6bb793aa51cbe9567e2e8271d6b8c249  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/bitcoin-d7d3bb1bbcc0-riscv64-linux-gnu-debug.tar.gz
17589b6f2646a70cf13443b9011cc5c9d88f4eed78460adfe4f430a8e38ae24df2  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/bitcoin-d7d3bb1bbcc0-riscv64-linux-gnu.tar.gz
18f122bd36048306e0b1dad07b0c482582309dad86c01c4c8c02496b90c16bb3ae  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/SHA256SUMS.part
191fc0e8d9ce6e9f6bcc20225a4f49cc494b02178244e18c8176aa3efb0984b305  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin-unsigned.tar.gz
20d90db4f98e11304af5340480eeb2d926bf788636d9df6d4f47dafb38842af78f  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin-unsigned.zip
218084a814ec7409a0e209f9049207e304215b5366e67661068398514a93c3bc13  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin.tar.gz
22ccf14469e17c447a40ea928944ca0f700d705ab87eb7dea42da5b78a645aeef7  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/SHA256SUMS.part
230e90253dbda704d0877515cfd95b33a0bf289fe6465002bf975b7f7c34a6779a  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/bitcoin-d7d3bb1bbcc0-x86_64-linux-gnu-debug.tar.gz
24a3f6985a8483b3b10a4382f185f34bd7c896a174cd2b980dfdf17627c8666135  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/bitcoin-d7d3bb1bbcc0-x86_64-linux-gnu.tar.gz
25f8bcaaff159238a6a06e9fe57d03984d4b1d97c0a23818809ef248e2290dc49a  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/SHA256SUMS.part
26057d47f78dbdf1efe0809e1172a3cc86797d925bcd2637e264b6d0b4d3777592  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-debug.zip
275579557e8ddcf4f6ab3b544c8a7905520abe1ab7a626f4aadaebf05098b76f9c  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-setup-unsigned.exe
2813d3e6570cd4da105f1c13bd11ac8596d773b95d2f3cbfb23fd8e42c0a771bcc  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-unsigned.tar.gz
29a6ff418aec9c1d50c758152394e4807f6d989fd94891f6e5f0c29a882dcbf542  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64.zip

fanquake approved

fanquake commented at 4:42 pm on January 20, 2025: member

ACK d7d3bb1bbcc0d9b03ac1d3b4e3a6a537fcff077d

fanquake commented at 4:52 pm on January 20, 2025: member

Spoke too soon. This change is not deterministic.

Guix Build (aarch64):

 0d5d3cf8a8cec671bccc5d1dee03f05f67dee52dfd543295d93e71b1338ae6abd  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/SHA256SUMS.part
 1f5f224be7a011f1465f995bb21a9f3af18567911272d795a937913370012d83f  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/bitcoin-d7d3bb1bbcc0-aarch64-linux-gnu-debug.tar.gz
 29e2e815f19be9f7e8480ce5c5bd2443b703e5134667ed3feb57fd2cd75ad9dae  guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/bitcoin-d7d3bb1bbcc0-aarch64-linux-gnu.tar.gz
 35d0abf903220760a6652409c9be75b4a0adcd21055778958b0ca6e254cb0d3b6  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/SHA256SUMS.part
 45596badf7fc9fd750ad1bd136e0c5d64e008fcc11b57c42f1644102e9b8e85e7  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/bitcoin-d7d3bb1bbcc0-arm-linux-gnueabihf-debug.tar.gz
 56cc5d27e5472d20e9c367506c13b4e41be2252ac3de9643da8179ba2567cd1c3  guix-build-d7d3bb1bbcc0/output/arm-linux-gnueabihf/bitcoin-d7d3bb1bbcc0-arm-linux-gnueabihf.tar.gz
 65e5c98ef215004ddc0b5415f56627138e94e53d958a3c00bebc76f38f377c3e5  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/SHA256SUMS.part
 78cc86debaee483678477092b40693c6f27acd2c58e4df2654327ab0b9583bbae  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin-unsigned.tar.gz
 8241be8a303e9111aee4cf0617a919ff476fb83c82a3345146c77a397069b94bd  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin-unsigned.zip
 90d96aee779b9062635dbebedf60ee7d37c83460295ca9fb64fedc0c2e2ccdddf  guix-build-d7d3bb1bbcc0/output/arm64-apple-darwin/bitcoin-d7d3bb1bbcc0-arm64-apple-darwin.tar.gz
10500751e3817551bbdb1377b7947bb666a34d018a018f01b5e4b035e221950f7c  guix-build-d7d3bb1bbcc0/output/dist-archive/bitcoin-d7d3bb1bbcc0.tar.gz
1138d0a65d05879713888d405e056ab46e00a1eeebccda8698a2f1bc990d769b2d  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/SHA256SUMS.part
128d6efeb86bad556ee510ddf3c0fac0c15cb257e884a057dd5f51c92dd4689653  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/bitcoin-d7d3bb1bbcc0-powerpc64-linux-gnu-debug.tar.gz
133a47e308df8f90253999d58eb98e11e0754c252b736171c0c8f36bbf986c0ace  guix-build-d7d3bb1bbcc0/output/powerpc64-linux-gnu/bitcoin-d7d3bb1bbcc0-powerpc64-linux-gnu.tar.gz
14ef09a59e0f71d807aa4c68cc4803ef798852b7710ac46e27b09b58dbec8fd841  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/SHA256SUMS.part
150de69c2c507243f2e0da67092e192edf6bb793aa51cbe9567e2e8271d6b8c249  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/bitcoin-d7d3bb1bbcc0-riscv64-linux-gnu-debug.tar.gz
16411ffdb06fbe57543ba2fbf112a43eebb0c33fc55d7be1228c6bc5d94ab6377d  guix-build-d7d3bb1bbcc0/output/riscv64-linux-gnu/bitcoin-d7d3bb1bbcc0-riscv64-linux-gnu.tar.gz
174cc835e7bceff7490010838e454aba643814bc1a35536c1cf2200a8c5a52b9b6  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/SHA256SUMS.part
189d64db19ba634888c773467c249fd85f7cb1b32621715e80a9481b8c2b29121e  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin-unsigned.tar.gz
19d0d045dad42c87ca6c39aabb7760e6a5c86ffdef112c7bde62ba25d2b5d28302  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin-unsigned.zip
209642fab24e8b57e47d015ec2faa95482551f1741f190b798a4b89b29a30f2b6e  guix-build-d7d3bb1bbcc0/output/x86_64-apple-darwin/bitcoin-d7d3bb1bbcc0-x86_64-apple-darwin.tar.gz
218737d91c062d41f2b14bc39a60b354d18966f5e5b98f08ff85ce3e0948e3c59a  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/SHA256SUMS.part
220e90253dbda704d0877515cfd95b33a0bf289fe6465002bf975b7f7c34a6779a  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/bitcoin-d7d3bb1bbcc0-x86_64-linux-gnu-debug.tar.gz
2326421408b850899fc11d08c1d363160edaf215cbddcce53a292686d54c191657  guix-build-d7d3bb1bbcc0/output/x86_64-linux-gnu/bitcoin-d7d3bb1bbcc0-x86_64-linux-gnu.tar.gz
24971cdac198218b377178730b088a4ee35f03df5f053bc426216a8e7e5d3f935f  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/SHA256SUMS.part
25057d47f78dbdf1efe0809e1172a3cc86797d925bcd2637e264b6d0b4d3777592  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-debug.zip
26cc558956b3cfb170f6e5db4499a5ce6d41a87c236187b273ba8d9cecfd17def3  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-setup-unsigned.exe
27b01709927b7e68588f05de7ce06a44ab604de6dd208acddc11033141719ee5d2  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64-unsigned.tar.gz
28a5f2e295890ea1d62833037128e2cfaa7625838b86af6e3689a943cb69298dd9  guix-build-d7d3bb1bbcc0/output/x86_64-w64-mingw32/bitcoin-d7d3bb1bbcc0-win64.zip

depends: Override default build type for libevent #31661

Code Coverage & Benchmarks

Reviews

depends: Override default build type for `libevent` #31661