Added rescan option for import descriptors #31668

1. 
   saikiran57 commented at 8:11 am on January 16, 2025: none

   Fix related to issue: #31263
2. Added rescan option for import descriptors

   issue: https://github.com/bitcoin/bitcoin/issues/31263

   1ae32a9eb5
3. 
   DrahtBot commented at 8:11 am on January 16, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31668.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label CI failed on Jan 16, 2025
5. 
   DrahtBot commented at 9:00 am on January 16, 2025: contributor

   🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/35699494417

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. 
   maflcko commented at 1:28 pm on January 16, 2025: member

   This needs a test and the tests fixed
7. in src/wallet/rpc/backup.cpp:1727 in 1ae32a9eb5

   1722@@ -1712,10 +1723,8 @@ RPCHelpMan importdescriptors()
   1723                 lowest_timestamp = timestamp;
   1724             }
   1725 
   1726-            // If we know the chain tip, and at least one request was successful then allow rescan
   1727-            if (!rescan && result["success"].get_bool()) {
   1728-                rescan = true;
   1729-            }
   1730+            // check rescan option for each request if any request set rescan
   1731+            rescan = GetImportRescan(request);
   

   ---

   ---

   

   furszy commented at 3:18 pm on January 17, 2025:

   This overrides the flag for each imported descriptor, meaning the final value depends solely on the last imported element.

Contributors
saikiran57 DrahtBot maflcko furszy

Labels
CI failed