[test] fix p2p_orphan_handling.py empty orphanage check #31675

pull glozow wants to merge 1 commits into bitcoin:master from glozow:2025-01-test-orphan-wait changing 1 files +1 −1
  1. glozow commented at 6:58 pm on January 16, 2025: member
  2. [test] fix p2p_orphan_handling.py empty orphanage check
    It's possible getorphantxs isn't empty immediately. Prevent intermittent errors.
    2e75ebb616
  3. glozow added the label Tests on Jan 16, 2025
  4. DrahtBot commented at 6:58 pm on January 16, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31675.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, instagibbs, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. maflcko commented at 7:06 pm on January 16, 2025: member

    lgtm ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec

    I guess this is a race from disconnecting the p2ps. So waiting seems the correct fix.

  6. maflcko added this to the milestone 29.0 on Jan 16, 2025
  7. instagibbs commented at 7:16 pm on January 16, 2025: member

    ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec

    don’t see any other problematic orphanage checks

  8. theStack approved
  9. theStack commented at 0:34 am on January 17, 2025: contributor
    ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec
  10. fanquake merged this on Jan 17, 2025
  11. fanquake closed this on Jan 17, 2025

  12. glozow removed this from the milestone 29.0 on Jan 18, 2025
  13. glozow deleted the branch on Jan 18, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me