Fix CI: https://cirrus-ci.com/task/4584274617171968?logs=ci#L2784
[test] fix p2p_orphan_handling.py empty orphanage check #31675
pull glozow wants to merge 1 commits into bitcoin:master from glozow:2025-01-test-orphan-wait changing 1 files +1 −1-
glozow commented at 6:58 PM on January 16, 2025: member
-
2e75ebb616
[test] fix p2p_orphan_handling.py empty orphanage check
It's possible getorphantxs isn't empty immediately. Prevent intermittent errors.
- glozow added the label Tests on Jan 16, 2025
-
DrahtBot commented at 6:58 PM on January 16, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31675.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, instagibbs, theStack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 7:06 PM on January 16, 2025: member
lgtm ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec
I guess this is a race from disconnecting the p2ps. So waiting seems the correct fix.
- maflcko added this to the milestone 29.0 on Jan 16, 2025
-
instagibbs commented at 7:16 PM on January 16, 2025: member
ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec
don't see any other problematic orphanage checks
- theStack approved
-
theStack commented at 12:34 AM on January 17, 2025: contributor
ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec
- fanquake merged this on Jan 17, 2025
- fanquake closed this on Jan 17, 2025
- glozow removed this from the milestone 29.0 on Jan 18, 2025
- glozow deleted the branch on Jan 18, 2025
- sedited referenced this in commit e1405325c9 on Feb 3, 2025
- stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
- stickies-v referenced this in commit cc83553352 on Mar 17, 2025
- stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
- stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
- stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
- bug-castercv502 referenced this in commit bf2e6853b0 on Sep 28, 2025
- bitcoin locked this on Jan 18, 2026
