contrib: Autoconf fragments left in test-*-check scripts #31698

1. 
   fanquake commented at 11:40 am on January 21, 2025: member

   The test-security-check and test-symbol-check scripts still reference Autoconf and it’s behaviour:

   0def env_flags() -> list[str]:
   1    # This should behave the same as AC_TRY_LINK, so arrange well-known flags
   2    # in the same order as autoconf would.
   3    #
   4    # See the definitions for ac_link in autoconf's lib/autoconf/c.m4 file for
   5    # reference.
   

   The also expect CPPFLAGS to be passed into them, but this isn’t happening from CMake:

   https://github.com/bitcoin/bitcoin/blob/d7f56cc5d9e12ad31dd1ce8b34c3ff4ec5c1b70c/cmake/module/Maintenance.cmake#L40

2. fanquake added the label Scripts and tools on Jan 21, 2025
3. fanquake added this to the milestone 29.0 on Jan 21, 2025
4. fanquake referenced this in commit 8f25a36e29 on Feb 7, 2025
5. fanquake referenced this in commit 4ec671a77f on Feb 7, 2025
6. fanquake referenced this in commit 485de09d9e on Feb 7, 2025
7. fanquake referenced this in commit 8d0824109c on Feb 7, 2025
8. fanquake referenced this in commit 76c090145e on Feb 10, 2025
9. fanquake referenced this in commit a44ccedcc2 on Feb 12, 2025
10. fanquake closed this on Feb 12, 2025

    ---

Contributors
fanquake

Labels
Scripts and tools

Milestone
29.0