Docs: fix typos in documentation files #31718
pull wgyt wants to merge 1 commits into bitcoin:master from wgyt:typo changing 5 files +5 −5-
wgyt commented at 3:52 am on January 23, 2025: contributor
-
DrahtBot commented at 3:52 am on January 23, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31718.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Docs on Jan 23, 2025
-
DrahtBot commented at 3:52 am on January 23, 2025: contributor📁 Archived release notes are archived and should not be modified.
-
DrahtBot added the label CI failed on Jan 23, 2025
-
DrahtBot commented at 3:58 am on January 23, 2025: contributor
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/36036780342
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
-
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
-
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
-
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
-
-
maflcko commented at 8:27 am on January 23, 2025: member
You can’t modify a subtree either.
Also, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
-
wgyt force-pushed on Jan 23, 2025
-
maflcko commented at 9:29 am on January 23, 2025: memberlgtm ACK c32bc14f5505f289aa66ce7a3608cd799e457699
-
in contrib/tracing/README.md:158 in c32bc14f55 outdated
154@@ -155,7 +155,7 @@ $ python3 contrib/tracing/log_raw_p2p_msgs.py $(pidof bitcoind) 155 156 ``` 157 Logging raw P2P messages. 158-Messages larger that about 32kb will be cut off!
l0rinc commented at 9:35 am on January 23, 2025:Please adjust https://github.com/bitcoin/bitcoin/blob/master/contrib/tracing/log_raw_p2p_msgs.py#L171 as well
wgyt commented at 1:17 am on January 24, 2025:Done. :)l0rinc changes_requestedDrahtBot removed the label CI failed on Jan 23, 2025fix typos 81b9800c87wgyt force-pushed on Jan 24, 2025maflcko commented at 7:48 am on January 24, 2025: memberlgtm ACK 81b9800c87e96c83a49cabd1eddcbef210387da5fanquake merged this on Jan 24, 2025fanquake closed this on Jan 24, 2025
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-07 18:12 UTC
More mirrored repositories can be found on mirror.b10c.me