contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.py #31742

1. 
   jurraca commented at 8:37 pm on January 27, 2025: contributor

   The gen-bitcoin-conf.sh and gen-manpages.py scripts assume a top level src/ build dir, but in-tree builds are no longer allowed, nor recommended in the build steps. If a user builds bitcoind as recommended, these scripts fail. To fix it, we update the BUILDDIR env var and update the README accordingly. Follows up on initial work and discussion in #31332 .
2. contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.py

   the cmake build steps suggest a build/ directory, which breaks these
   scripts. Additionally, in-tree builds are no longer allowed, so it makes
   sense to update the code and the README accordingly.

   63a8791e15
3. 
   DrahtBot commented at 8:37 pm on January 27, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31742.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31161 (cmake: Set top-level target output locations by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Scripts and tools on Jan 27, 2025
5. 
   fjahr commented at 8:46 pm on January 27, 2025: contributor

   Concept ACK

   I agree that referencing in-tree builds doesn’t make sense if we disallowed them with cmake.

6. fanquake added this to the milestone 29.0 on Feb 20, 2025
7. 
   fanquake commented at 5:31 pm on February 20, 2025: member

   Added to 29.0 as at least the in-tree build mentions should be removed.
8. 
   fjahr commented at 5:43 pm on February 20, 2025: contributor

   Code review ACK 63a8791e15c3ffb44b84ab3e85db62d7997d25fd
9. 
   achow101 commented at 7:49 pm on February 20, 2025: member

   ACK 63a8791e15c3ffb44b84ab3e85db62d7997d25fd
10. achow101 merged this on Feb 20, 2025
11. achow101 closed this on Feb 20, 2025

    ---

12. jurraca deleted the branch on Feb 20, 2025

Contributors
jurraca DrahtBot fjahr fanquake achow101

Labels
Scripts and tools

Milestone
29.0