We currently only sanity check CheckBlock()
in ConnectBlock()
. Not running the rest of the block
checks makes it hard to reason about upgrade edge cases if we were to introduce new consensus rules
(which would necessarily be context-dependent checks). For instance a timewarp fix or a BIP34
supplementation.
This is fine to do as the expensive check in ContextualCheckBlock()
is cached since
1ec6bbeb8d27d31647d1433ccb87b362f6d81f90 and the future-timestamp check is split out of
ContextualCheckBlockHeader()
beforehand.