wallet: abandon orphan coinbase txs, and their descendants, during startup #31794

pull furszy wants to merge 2 commits into bitcoin:master from furszy:2025_wallet_abandon_coinbase_during_startup changing 4 files +82 −5
  1. furszy commented at 4:17 pm on February 4, 2025: member

    Since #26499, we mark coinbase transactions and their descendants as abandoned when a reorg arises through the “block disconnection” signal handler. However, this does not cover all scenarios; external wallets could contain coinbase transactions from blocks the node has not seen yet, or the user could have replaced the chain with an earlier or different version (one without the coinbase chain).

    This affects balance calculation as well as mempool rebroadcast (descendants shouldn’t be relayed). Fix this by marking orphaned coinbase transactions and their descendants as abandoned during wallet startup.

  2. wallet: abandon inactive coinbase tx and their descendants during startup 474139aa9b
  3. test: wallet, abandon coinbase txs and their descendants during startup 0331060d13
  4. DrahtBot commented at 4:17 pm on February 4, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31794.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  5. DrahtBot added the label Wallet on Feb 4, 2025
  6. DrahtBot added the label CI failed on Feb 4, 2025
  7. furszy commented at 8:09 pm on February 4, 2025: member
    Test failure is unrelated.
  8. DrahtBot removed the label CI failed on Feb 4, 2025


furszy DrahtBot

Labels
Wallet


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-07 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me