lint: Qt exclusions are missing files #31801

issue fanquake openend this issue on February 5, 2025
  1. fanquake commented at 3:08 pm on February 5, 2025: member

    The tidy job is meant to skip linting autogenerated Qt files:

    https://github.com/bitcoin/bitcoin/blob/b9c241804c0726737a0eb80f6f27e94ef341b42e/ci/test/03_test_script.sh#L173-L174

    however it is currently linting and include checking CMake generated files. i.e (https://cirrus-ci.com/task/5702771191578624?logs=ci#L3386):

    0[09:40:22.499] [ 20/666][2.6s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/qt/bitcoinqt_autogen/EWIEGA46WW/qrc_bitcoin.cpp
    1[09:46:45.492] [326/666][12.3s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/qt/bitcoinqt_autogen/mocs_compilation.cpp
    2[09:51:12.546] [527/666][26.7s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/qt/bitcoinqt_autogen/EJRQKI7XPS/qrc_bitcoin_locale.cpp
    3[10:00:58.530] (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/qt/bitcoinqt_autogen/mocs_compilation.cpp has correct #includes/fwd-decls)
    
  2. maflcko commented at 3:39 pm on February 5, 2025: member
    I guess longer term this may be fixed by #31308 , but I haven’t confirmed this.
  3. maflcko added the label Tests on Feb 5, 2025
  4. fanquake closed this on Feb 21, 2025

  5. fanquake referenced this in commit f0ac24846f on Feb 21, 2025


fanquake maflcko

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me