ci: Remove no longer needed -Wno-error=documentation #31804

1. 
   hebasto commented at 5:25 pm on February 5, 2025: member

   Picked from #31726.
2. ci: Remove no longer needed '-Wno-error=documentation' f1d7a6dfa1
3. hebasto added the label Tests on Feb 5, 2025
4. 
   DrahtBot commented at 5:25 pm on February 5, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31804.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. hebasto renamed this:
   ci: Remove no longer needed '-Wno-error=documentation'
   ci: Remove no longer needed `-Wno-error=documentation`
   on Feb 5, 2025
6. 
   maflcko commented at 5:46 pm on February 5, 2025: member

   lgtm ACK f1d7a6dfa1411ccf741fbf7351ea4f229dd1e63e

   Not sure why and since when this is no longer needed. I am happy to bisect, if someone is interested.

7. 
   hebasto commented at 5:50 pm on February 5, 2025: member

   Not sure why and since when this is no longer needed. I am happy to bisect, if someone is interested.

   From https://github.com/bitcoin/bitcoin/commit/b088062e687d95deff28b0715fd4859449b56584 it follows that it comes “from Boost Test code”. CMake adds dependencies’ include directories with -isystem, which effectively silences warnings.

8. 
   theuni commented at 0:01 am on February 6, 2025: member

   It would be really nice to add comments for these in the future, whenever we add them. So it’s clear when/why they can be removed.

   (I guess git gave away the answer very quickly, but it’d be easier to eyeball and immediately understand if something’s still relevant)

9. fanquake merged this on Feb 6, 2025
10. fanquake closed this on Feb 6, 2025

    ---

11. hebasto deleted the branch on Feb 6, 2025

Contributors
hebasto DrahtBot maflcko theuni

Labels
Tests