Picked from #31726.
ci: Remove no longer needed `-Wno-error=documentation` #31804
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250205-ci-flags changing 1 files +0 −1-
hebasto commented at 5:25 PM on February 5, 2025: member
-
ci: Remove no longer needed '-Wno-error=documentation' f1d7a6dfa1
- hebasto added the label Tests on Feb 5, 2025
-
DrahtBot commented at 5:25 PM on February 5, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31804.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- hebasto renamed this:
ci: Remove no longer needed '-Wno-error=documentation'
ci: Remove no longer needed `-Wno-error=documentation`
on Feb 5, 2025 -
maflcko commented at 5:46 PM on February 5, 2025: member
lgtm ACK f1d7a6dfa1411ccf741fbf7351ea4f229dd1e63e
Not sure why and since when this is no longer needed. I am happy to bisect, if someone is interested.
-
hebasto commented at 5:50 PM on February 5, 2025: member
Not sure why and since when this is no longer needed. I am happy to bisect, if someone is interested.
From https://github.com/bitcoin/bitcoin/commit/b088062e687d95deff28b0715fd4859449b56584 it follows that it comes "from Boost Test code". CMake adds dependencies' include directories with
-isystem, which effectively silences warnings. -
theuni commented at 12:01 AM on February 6, 2025: member
It would be really nice to add comments for these in the future, whenever we add them. So it's clear when/why they can be removed.
(I guess git gave away the answer very quickly, but it'd be easier to eyeball and immediately understand if something's still relevant)
- fanquake merged this on Feb 6, 2025
- fanquake closed this on Feb 6, 2025
- hebasto deleted the branch on Feb 6, 2025
- sedited referenced this in commit f78a01a560 on Feb 22, 2025
- stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
- stickies-v referenced this in commit cc83553352 on Mar 17, 2025
- stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
- stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
- stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
- bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
- bitcoin locked this on Feb 6, 2026
Labels