guix: remove test-security/symbol-check scripts #31818

1. 
   fanquake commented at 3:57 pm on February 7, 2025: member

   These scripts are becoming more of nuisance, than a value-add; particularly since we’ve been building releases using Guix. Adding new (release bin) tests can be harder, because it requires constructing a failing test, which is becoming less easy, e.g trying to disable a feature or protection that has been built into the compiler/toolchain by default.

   In the pre-Guix days, these were valuable to sanity-check the environment, because we were pulling that pre-built from Ubuntu, with little control. At this point, it’s less clear what these scripts are (sanity) checking.

   Note that these also weren’t completely ported to CMake (#31698), see also #31715 which contains other fixes that would be needed for these test-tests, to accomodate future changes.

2. 
   DrahtBot commented at 3:57 pm on February 7, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31818.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31375 (multiprocess: Add bitcoin wrapper executable by ryanofsky)
   • #31233 (cmake: Improve robustness and usability by hebasto)
   • #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Build system on Feb 7, 2025
4. theuni approved
5. 
   theuni commented at 5:32 pm on February 7, 2025: member

   utACK 485de09d9edff6abd6eef9e54e70b21bf6ceb9e4.

   I opened #31715 to “fix” some issues with these, but I was really struggling to understand what good those tests were doing at all. I agree they’ve outlived their utility. At this point they’re basically hard-coded things checking for hard-coded things. I proposed those fixes merely to “make tests turn green” as opposed to doing something useful. I agree that just deleting them makes more sense.

   Note to other reviewers, this doesn’t remove any of our actual security/symbol checks.

6. 
   hebasto commented at 9:49 am on February 8, 2025: member

   In the pre-Guix days, these were valuable to sanity-check the environment, because we were pulling that pre-built from Ubuntu, with little control. At this point, it’s less clear what these scripts are (sanity) checking.

   Concept ACK.

7. guix: remove test-security/symbol-check scripts

   These scripts are becoming more of nuisance, than a value-add;
   particularly since we've been building releases using Guix. Adding new
   (release bin) tests can be harder, because it requires constructing a
   failing test, which is becoming less easy e.g trying to disable a
   feature or protection that has been built into the compiler/toolchain by
   default.
   
   In the pre-Guix days, these were valuable to sanity-check the environment,
   because we were pulling that pre-built from Ubuntu, with little control.
   At this point, it's less clear what these scripts are (sanity) checking.
   
   Note that these also weren't completely ported to CMake (#31698), see
   also #31715 which contains other fixes that would be needed for these
   test-tests, to accomodate future changes.

   76c090145e
8. in cmake/module/Maintenance.cmake:34 in 485de09d9e outdated

   30@@ -31,17 +31,6 @@ function(add_maintenance_targets)
   31     set(exe_format ELF)
   32   endif()
   33 
   34-  # In CMake, the components of the compiler invocation are separated into distinct variables:
   

   ---

   ---

   

   hebasto commented at 10:08 am on February 10, 2025:

   The block above, which sets the exe_format variable, can now be deleted entirely.

   ---

   

   fanquake commented at 10:21 am on February 10, 2025:

   Dropped.
9. fanquake force-pushed on Feb 10, 2025
10. hebasto approved
11. 
    hebasto commented at 12:47 pm on February 10, 2025: member

    ACK 76c090145e9bb64fe4ef6a663723dd0e9028ed10.

    My Guix build:

     0aarch64
     14756d1c55efefe2dd3429d93060555617bb00709772a3c13638aab8c8dd9af2c  guix-build-76c090145e9b/output/aarch64-linux-gnu/SHA256SUMS.part
     2f9fe3c2cb751060366eae0070a1c91897ac49c74bfc53baafca65cb17413ce7e  guix-build-76c090145e9b/output/aarch64-linux-gnu/bitcoin-76c090145e9b-aarch64-linux-gnu-debug.tar.gz
     36532576a94838e11f8aa98b037f116af32b71eb6f446f67ffc451207b442fd36  guix-build-76c090145e9b/output/aarch64-linux-gnu/bitcoin-76c090145e9b-aarch64-linux-gnu.tar.gz
     47ed8370d29955a041662726611b1abb30b04d801423ea01384c1dead672babbc  guix-build-76c090145e9b/output/arm-linux-gnueabihf/SHA256SUMS.part
     505b9cb483ce1a9a6f9afcc1e6c118f083c6d80ef433c98546e5e8b3999f30ba5  guix-build-76c090145e9b/output/arm-linux-gnueabihf/bitcoin-76c090145e9b-arm-linux-gnueabihf-debug.tar.gz
     614100353e83fdd2a11c97e1698a40ce922749e6bf7408a3355cbbdd8a77d8da3  guix-build-76c090145e9b/output/arm-linux-gnueabihf/bitcoin-76c090145e9b-arm-linux-gnueabihf.tar.gz
     7cef111a5974a021ac289ab3baa4396eb3fac98bba9f35cb39c1aab15958dce07  guix-build-76c090145e9b/output/arm64-apple-darwin/SHA256SUMS.part
     8161d392e1b912aedec2aaede226e467f52ef16f34cb81f35b5fee7f819c97853  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin-unsigned.tar.gz
     914e3da7a5f5ad1638bf76ca74ef9e2152a94a01eb9dffca5874a3ddd4d31d516  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin-unsigned.zip
    10ff1e39a9197fddf841cad699e02c4e24f7e6c0b4be45e8cda4671cfc6b14c33e  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin.tar.gz
    1150e9bf5d0c2bba3d7f6c64d59acad0fe58c923ec642e243c7e54e271ab2917c4  guix-build-76c090145e9b/output/dist-archive/bitcoin-76c090145e9b.tar.gz
    12e7bc473f2f96773ab6d735de0c1bc9602031e48b39b4737d9468302d291b2f42  guix-build-76c090145e9b/output/powerpc64-linux-gnu/SHA256SUMS.part
    13023e557e2194f95c2b3ff086075509f88795c0dacf8506977840ef0c82755a79  guix-build-76c090145e9b/output/powerpc64-linux-gnu/bitcoin-76c090145e9b-powerpc64-linux-gnu-debug.tar.gz
    14d0b31c8c28354c1a483dce53ba62e944d1be0fbca8affe22c64f967b8ffeabbc  guix-build-76c090145e9b/output/powerpc64-linux-gnu/bitcoin-76c090145e9b-powerpc64-linux-gnu.tar.gz
    1583b965eeb5439cc342ed0516743ded9535ced3e06e10c885ab7b927fc1e7a477  guix-build-76c090145e9b/output/riscv64-linux-gnu/SHA256SUMS.part
    164245a858ba84132dfb739d2a561f022cc34b82072223946e38beba30fdd1276b  guix-build-76c090145e9b/output/riscv64-linux-gnu/bitcoin-76c090145e9b-riscv64-linux-gnu-debug.tar.gz
    1767bce1c84bc34e614f0229f65d2bdc8bd4bbdf56b544feab2ed9599e8590445c  guix-build-76c090145e9b/output/riscv64-linux-gnu/bitcoin-76c090145e9b-riscv64-linux-gnu.tar.gz
    18e003f73f82f43bd17f900d7a21c79eed93d9be0a05159e52c6313cc02e88bc7d  guix-build-76c090145e9b/output/x86_64-apple-darwin/SHA256SUMS.part
    19d8cf117c0898741ce54e6071c72140d0b79f0fe3597634b906682a8b047082f1  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin-unsigned.tar.gz
    2062f3b5b6d5998d2f15a5033dd4bac7599fe4856ecc8a4add2ca72e43e965a9d3  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin-unsigned.zip
    219122d98568a8adf6f9e858abbf33583753ae755f50cefe8304c03fab4e209e47  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin.tar.gz
    22e2bf85dceb5c9dd011c591622de8522d8f2d77fdc6d43f9d1b22e5be424e9111  guix-build-76c090145e9b/output/x86_64-linux-gnu/SHA256SUMS.part
    23f25aee6fd65608f462a4b04c30d6bb1bbca8a6d1b049e2cb097af61d260f36c6  guix-build-76c090145e9b/output/x86_64-linux-gnu/bitcoin-76c090145e9b-x86_64-linux-gnu-debug.tar.gz
    245b0aa62d9491a31ba680508f5643ae4ccdfa307e761a2301fafd9e6fc026e51a  guix-build-76c090145e9b/output/x86_64-linux-gnu/bitcoin-76c090145e9b-x86_64-linux-gnu.tar.gz
    2501b1fc7b38d2fefbefe759cbdaff9eb867f14d7096317b0260c8d4fc0a36d8f4  guix-build-76c090145e9b/output/x86_64-w64-mingw32/SHA256SUMS.part
    260f1ac6fc5689f0301574dcc7fab292e56ad78b71b9e69804195ec383d10c71c6  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-debug.zip
    2793d745a62df3e1c9adde3e94e97573b52ab0254da509740ff3a5b4b45418632e  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-setup-unsigned.exe
    28232992d3704e484f24f91d519bea388759237662aa5b5f2415dd2c534270aab3  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-unsigned.tar.gz
    299f792ab8b9182e769f65fd70111ae7d57ca719bd2440f6e3b80554bb2c57a91c  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64.zip
    

12. DrahtBot requested review from theuni on Feb 10, 2025
13. 
    fanquake commented at 9:46 am on February 11, 2025: member

    Guix Build:

     04756d1c55efefe2dd3429d93060555617bb00709772a3c13638aab8c8dd9af2c  guix-build-76c090145e9b/output/aarch64-linux-gnu/SHA256SUMS.part
     1f9fe3c2cb751060366eae0070a1c91897ac49c74bfc53baafca65cb17413ce7e  guix-build-76c090145e9b/output/aarch64-linux-gnu/bitcoin-76c090145e9b-aarch64-linux-gnu-debug.tar.gz
     26532576a94838e11f8aa98b037f116af32b71eb6f446f67ffc451207b442fd36  guix-build-76c090145e9b/output/aarch64-linux-gnu/bitcoin-76c090145e9b-aarch64-linux-gnu.tar.gz
     37ed8370d29955a041662726611b1abb30b04d801423ea01384c1dead672babbc  guix-build-76c090145e9b/output/arm-linux-gnueabihf/SHA256SUMS.part
     405b9cb483ce1a9a6f9afcc1e6c118f083c6d80ef433c98546e5e8b3999f30ba5  guix-build-76c090145e9b/output/arm-linux-gnueabihf/bitcoin-76c090145e9b-arm-linux-gnueabihf-debug.tar.gz
     514100353e83fdd2a11c97e1698a40ce922749e6bf7408a3355cbbdd8a77d8da3  guix-build-76c090145e9b/output/arm-linux-gnueabihf/bitcoin-76c090145e9b-arm-linux-gnueabihf.tar.gz
     6cef111a5974a021ac289ab3baa4396eb3fac98bba9f35cb39c1aab15958dce07  guix-build-76c090145e9b/output/arm64-apple-darwin/SHA256SUMS.part
     7161d392e1b912aedec2aaede226e467f52ef16f34cb81f35b5fee7f819c97853  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin-unsigned.tar.gz
     814e3da7a5f5ad1638bf76ca74ef9e2152a94a01eb9dffca5874a3ddd4d31d516  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin-unsigned.zip
     9ff1e39a9197fddf841cad699e02c4e24f7e6c0b4be45e8cda4671cfc6b14c33e  guix-build-76c090145e9b/output/arm64-apple-darwin/bitcoin-76c090145e9b-arm64-apple-darwin.tar.gz
    1050e9bf5d0c2bba3d7f6c64d59acad0fe58c923ec642e243c7e54e271ab2917c4  guix-build-76c090145e9b/output/dist-archive/bitcoin-76c090145e9b.tar.gz
    11e7bc473f2f96773ab6d735de0c1bc9602031e48b39b4737d9468302d291b2f42  guix-build-76c090145e9b/output/powerpc64-linux-gnu/SHA256SUMS.part
    12023e557e2194f95c2b3ff086075509f88795c0dacf8506977840ef0c82755a79  guix-build-76c090145e9b/output/powerpc64-linux-gnu/bitcoin-76c090145e9b-powerpc64-linux-gnu-debug.tar.gz
    13d0b31c8c28354c1a483dce53ba62e944d1be0fbca8affe22c64f967b8ffeabbc  guix-build-76c090145e9b/output/powerpc64-linux-gnu/bitcoin-76c090145e9b-powerpc64-linux-gnu.tar.gz
    1483b965eeb5439cc342ed0516743ded9535ced3e06e10c885ab7b927fc1e7a477  guix-build-76c090145e9b/output/riscv64-linux-gnu/SHA256SUMS.part
    154245a858ba84132dfb739d2a561f022cc34b82072223946e38beba30fdd1276b  guix-build-76c090145e9b/output/riscv64-linux-gnu/bitcoin-76c090145e9b-riscv64-linux-gnu-debug.tar.gz
    1667bce1c84bc34e614f0229f65d2bdc8bd4bbdf56b544feab2ed9599e8590445c  guix-build-76c090145e9b/output/riscv64-linux-gnu/bitcoin-76c090145e9b-riscv64-linux-gnu.tar.gz
    17e003f73f82f43bd17f900d7a21c79eed93d9be0a05159e52c6313cc02e88bc7d  guix-build-76c090145e9b/output/x86_64-apple-darwin/SHA256SUMS.part
    18d8cf117c0898741ce54e6071c72140d0b79f0fe3597634b906682a8b047082f1  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin-unsigned.tar.gz
    1962f3b5b6d5998d2f15a5033dd4bac7599fe4856ecc8a4add2ca72e43e965a9d3  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin-unsigned.zip
    209122d98568a8adf6f9e858abbf33583753ae755f50cefe8304c03fab4e209e47  guix-build-76c090145e9b/output/x86_64-apple-darwin/bitcoin-76c090145e9b-x86_64-apple-darwin.tar.gz
    21e2bf85dceb5c9dd011c591622de8522d8f2d77fdc6d43f9d1b22e5be424e9111  guix-build-76c090145e9b/output/x86_64-linux-gnu/SHA256SUMS.part
    22f25aee6fd65608f462a4b04c30d6bb1bbca8a6d1b049e2cb097af61d260f36c6  guix-build-76c090145e9b/output/x86_64-linux-gnu/bitcoin-76c090145e9b-x86_64-linux-gnu-debug.tar.gz
    235b0aa62d9491a31ba680508f5643ae4ccdfa307e761a2301fafd9e6fc026e51a  guix-build-76c090145e9b/output/x86_64-linux-gnu/bitcoin-76c090145e9b-x86_64-linux-gnu.tar.gz
    2401b1fc7b38d2fefbefe759cbdaff9eb867f14d7096317b0260c8d4fc0a36d8f4  guix-build-76c090145e9b/output/x86_64-w64-mingw32/SHA256SUMS.part
    250f1ac6fc5689f0301574dcc7fab292e56ad78b71b9e69804195ec383d10c71c6  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-debug.zip
    2693d745a62df3e1c9adde3e94e97573b52ab0254da509740ff3a5b4b45418632e  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-setup-unsigned.exe
    27232992d3704e484f24f91d519bea388759237662aa5b5f2415dd2c534270aab3  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64-unsigned.tar.gz
    289f792ab8b9182e769f65fd70111ae7d57ca719bd2440f6e3b80554bb2c57a91c  guix-build-76c090145e9b/output/x86_64-w64-mingw32/bitcoin-76c090145e9b-win64.zip
    

14. theuni approved
15. 
    theuni commented at 4:38 pm on February 11, 2025: member

    utACK 76c090145e9bb64fe4ef6a663723dd0e9028ed10
16. fanquake merged this on Feb 12, 2025
17. fanquake closed this on Feb 12, 2025

    ---

18. fanquake deleted the branch on Feb 12, 2025

Contributors
fanquake DrahtBot theuni hebasto

Labels
Build system