depends: set CMAKE_*_COMPILER_TARGET in toolchain #31849

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:clang_cross_toolchain changing 2 files +5 −0
  1. fanquake commented at 5:00 pm on February 12, 2025: member

    According to the CMake docs, this is the correct way to setup a toolchain file for cross-compilation using Clang. See https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-using-clang

    Internally it looks like CMake will only take this variable into account if it detects the compiler to be Clang, so this shouldn’t effect other builds, but in the case of our Apple cross builds, we’d end up with a duplicated --target=$ARCH-apple-darwin on the compiler line, given we are already setting --target for Darwin builds.

    Would fix #31748.

  2. DrahtBot commented at 5:00 pm on February 12, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31849.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto
    Concept ACK theuni, willcl-ark

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Build system on Feb 12, 2025
  4. theuni commented at 7:35 pm on February 13, 2025: member

    Concept ACK. Regarding the duplicate --target… this kind of thing has come up a few times now where we need to add something to cc/flags for depends but we don’t want it exported in our toolchain. I have a branch where I’ve done something similar.

    Additionally, for Xcode generators (and CMake 4.0), I think we’ll want to handle the macOS sdk/include paths differently between depends and the toolchain file, since CMake has specific variables that it really wants set for handling those things, rather than making them part of the compiler.

    I think it makes sense to go ahead and add an abstraction for stuff we want for our depends builds that we don’t want exported to the toolchain. I’ll work a PR for that for discussion.

    That’s not a blocker for this though, I don’t think duplicate --target is the end of the world.

  5. in depends/toolchain.cmake.in:18 in ec8c198d94 outdated 
    12@@ -13,6 +13,9 @@ if(@depends_crosscompiling@)
13   set(CMAKE_SYSTEM_NAME @host_system_name@)
14   set(CMAKE_SYSTEM_VERSION @host_system_version@)
15   set(CMAKE_SYSTEM_PROCESSOR @host_arch@)
16+
17+  set(CMAKE_C_COMPILER_TARGET @host@)
18+  set(CMAKE_CXX_COMPILER_TARGET @host@)
    hebasto commented at 9:16 am on February 14, 2025:
    Add set(CMAKE_OBJCXX_COMPILER_TARGET [@host](/bitcoin-bitcoin/contributor/host/)@)?
    fanquake commented at 10:17 am on February 14, 2025:
    Added.
  6. hebasto commented at 9:16 am on February 14, 2025: member

    Concept ACK on using as many CMake’s abstractions as possible.

    We already use them in depends:https://github.com/bitcoin/bitcoin/blob/2549fc6fd1cc958a0e2d59838907c8808fd129b3/depends/funcs.mk#L194-L198

    … we’d end up with a duplicated --target=$ARCH-apple-darwin on the compiler line

    This will become a persistent source of confusion and complains, which could, of course, just be ignored. That was the only reason why I initially refrained from using CMAKE_<LANG>_COMPILER_TARGET while working on the staging branch.

    Would it be worth filtering out --target=$ARCH-apple-darwin from CMAKE_<LANG>_COMPILER in the toolchain file?

  7. fanquake force-pushed on Feb 14, 2025
  8. fanquake commented at 10:20 am on February 14, 2025: member

    This will become a persistent source of confusion and complains,

    It’s only visible during a verbose build, and only happens when cross-compiling for macOS, on Linux. Which is certainly a less common build for anyone to actually be doing (outside of a Guix build, where it also wouldn’t be visible).

    Would it be worth filtering out –target=$ARCH-apple-darwin from CMAKE__COMPILER in the toolchain file?

    It probably depends on how much code is needed, but I’m not sure filtering should be done unless its generic.

  9. hebasto commented at 11:26 am on February 14, 2025: member

    Would it be worth filtering out –target=$ARCH-apple-darwin from CMAKE__COMPILER in the toolchain file?

    It probably depends on how much code is needed, but I’m not sure filtering should be done unless its generic.

    For example:

     0--- a/depends/toolchain.cmake.in
 1+++ b/depends/toolchain.cmake.in
 2@@ -29,8 +29,15 @@ if(NOT DEFINED CMAKE_C_FLAGS_DEBUG_INIT)
 3   set(CMAKE_C_FLAGS_DEBUG_INIT "@CFLAGS_DEBUG@")
 4 endif()
 5 
 6+macro(fliter_flags compiler_invocation_line)
 7+  if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
 8+    list(FILTER ${compiler_invocation_line} EXCLUDE REGEX "--target=@host@")
 9+  endif()
10+endmacro()
11+
12 if(NOT DEFINED CMAKE_C_COMPILER)
13   set(CMAKE_C_COMPILER [@CC](/bitcoin-bitcoin/contributor/cc/)@)
14+  fliter_flags(CMAKE_C_COMPILER)
15 endif()
16 
17 if(NOT DEFINED CMAKE_CXX_FLAGS_INIT)
18@@ -48,6 +55,7 @@ endif()
19 
20 if(NOT DEFINED CMAKE_CXX_COMPILER)
21   set(CMAKE_CXX_COMPILER [@CXX](/bitcoin-bitcoin/contributor/cxx/)@)
22+  fliter_flags(CMAKE_CXX_COMPILER)
23   set(CMAKE_OBJCXX_COMPILER ${CMAKE_CXX_COMPILER})
24 endif()
25
  10. fanquake force-pushed on Mar 7, 2025
  11. fanquake commented at 11:42 am on March 7, 2025: member

    For example:

    I’m not entirely convinced, given this isn’t generic. If duplicate flags is an issue, then we should be doing the same for duplication that already exists (in non-verbose builds), not just for this specific case.

  12. hebasto commented at 11:54 am on March 7, 2025: member

    For example:

    I’m not entirely convinced, given this isn’t generic. If duplicate flags is an issue, then we should be doing the same for duplication that already exists (in non-verbose builds), not just for this specific case.

    I don’t think that duplicate flags can break the build. It is rather a readability issue and a potential source of confusion.

    What are other flags are duplicated now?

  13. fanquake commented at 11:58 am on March 7, 2025: member

    What are other flags are duplicated now?

    Any depends build currently has duplicated -O flags, i.e: https://cirrus-ci.com/task/5474870093414400?logs=ci#L852.

  14. fanquake force-pushed on Mar 12, 2025
  15. fanquake force-pushed on Mar 14, 2025
  16. willcl-ark commented at 12:20 pm on March 18, 2025: member

    Concept ACK

    I forgot about this issue then bumped into it in docker again today trying to add the ability to cross-compile to arm64 to my Dockerfile:

     0[#14](/bitcoin-bitcoin/14/) 92.71 /usr/bin/ld: /src/bitcoin/depends/aarch64-linux-gnu/lib/libevent_core.a(buffer.c.o): Relocations in generic ELF (EM: 183)
 1[#14](/bitcoin-bitcoin/14/) 92.71 /usr/bin/ld: /src/bitcoin/depends/aarch64-linux-gnu/lib/libevent_core.a(buffer.c.o): Relocations in generic ELF (EM: 183)
 2[#14](/bitcoin-bitcoin/14/) 92.71 /usr/bin/ld: /src/bitcoin/depends/aarch64-linux-gnu/lib/libevent_core.a: error adding symbols: file in wrong format
 3[#14](/bitcoin-bitcoin/14/) 92.71 clang: error: linker command failed with exit code 1 (use -v to see invocation)
 4[#14](/bitcoin-bitcoin/14/) 92.71 gmake[2]: *** [src/CMakeFiles/bitcoin-cli.dir/build.make:108: bin/bitcoin-cli] Error 1
 5[#14](/bitcoin-bitcoin/14/) 92.71 gmake[1]: *** [CMakeFiles/Makefile2:678: src/CMakeFiles/bitcoin-cli.dir/all] Error 2
 6[#14](/bitcoin-bitcoin/14/) 92.71 gmake[1]: *** Waiting for unfinished jobs....
 7[#14](/bitcoin-bitcoin/14/) 92.80 [ 98%] Built target bitcoin-tx
 8[#14](/bitcoin-bitcoin/14/) 98.33 [ 98%] Linking CXX static library ../lib/libbitcoin_node.a
 9[#14](/bitcoin-bitcoin/14/) 98.76 [ 98%] Built target bitcoin_node
10[#14](/bitcoin-bitcoin/14/) 98.76 gmake: *** [Makefile:136: all] Error 2
11[#14](/bitcoin-bitcoin/14/) ERROR: process "/bin/sh -c set -ex   && cmake -B build --toolchain \"depends/$HOST/toolchain.cmake\"     -DBUILD_TESTS=OFF     -DBUILD_TX=ON     -DBUILD_UTIL=OFF     -DCMAKE_BUILD_TYPE=RelWithDebInfo     -DCMAKE_CXX_COMPILER=clang++-16     -DCMAKE_C_COMPILER=clang-16     -DCMAKE_INSTALL_PREFIX:PATH=\"${BITCOIN_PREFIX}\"     -DWITH_CCACHE=ON   && cmake --build build -j$(nproc)   && strip build/bin/bitcoin-cli build/bin/bitcoin-tx build/bin/bitcoind   && cmake --install build" did not complete successfully: exit code: 2
12------
13 > [build 9/9] RUN set -ex   && cmake -B build --toolchain "depends/aarch64-linux-gnu/toolchain.cmake"     -DBUILD_TESTS=OFF     -DBUILD_TX=ON     -DBUILD_UTIL=OFF     -DCMAKE_BUILD_TYPE=RelWithDebInfo     -DCMAKE_CXX_COMPILER=clang++-16     -DCMAKE_C_COMPILER=clang-16     -DCMAKE_INSTALL_PREFIX:PATH="/opt/bitcoin"     -DWITH_CCACHE=ON   && cmake --build build -j$(nproc)   && strip build/bin/bitcoin-cli build/bin/bitcoin-tx build/bin/bitcoind   && cmake --install build:
1492.71 /usr/bin/ld: /src/bitcoin/depends/aarch64-linux-gnu/lib/libevent_core.a(buffer.c.o): Relocations in generic ELF (EM: 183)
1592.71 /usr/bin/ld: /src/bitcoin/depends/aarch64-linux-gnu/lib/libevent_core.a: error adding symbols: file in wrong format
1692.71 clang: error: linker command failed with exit code 1 (use -v to see invocation)
1792.71 gmake[2]: *** [src/CMakeFiles/bitcoin-cli.dir/build.make:108: bin/bitcoin-cli] Error 1
1892.71 gmake[1]: *** [CMakeFiles/Makefile2:678: src/CMakeFiles/bitcoin-cli.dir/all] Error 2
1992.71 gmake[1]: *** Waiting for unfinished jobs....
2092.80 [ 98%] Built target bitcoin-tx
2198.33 [ 98%] Linking CXX static library ../lib/libbitcoin_node.a
2298.76 [ 98%] Built target bitcoin_node
2398.76 gmake: *** [Makefile:136: all] Error 2
24------
25Dockerfile:52
26--------------------
27  51 |
28  52 | >>> RUN set -ex \
29  53 | >>>   && cmake -B build --toolchain "depends/$HOST/toolchain.cmake" \
30  54 | >>>     -DBUILD_TESTS=OFF \
31  55 | >>>     -DBUILD_TX=ON \
32  56 | >>>     -DBUILD_UTIL=OFF \
33  57 | >>>     -DCMAKE_BUILD_TYPE=RelWithDebInfo \
34  58 | >>>     -DCMAKE_CXX_COMPILER=clang++-16 \
35  59 | >>>     -DCMAKE_C_COMPILER=clang-16 \
36  60 | >>>     -DCMAKE_INSTALL_PREFIX:PATH="${BITCOIN_PREFIX}" \
37  61 | >>>     -DWITH_CCACHE=ON \
38  62 | >>>   && cmake --build build -j$(nproc) \
39  63 | >>>   && strip build/bin/bitcoin-cli build/bin/bitcoin-tx build/bin/bitcoind \
40  64 | >>>   && cmake --install build
41  65 |
42--------------------
43ERROR: failed to solve: process "/bin/sh -c set -ex   && cmake -B build --toolchain \"depends/$HOST/toolchain.cmake\"     -DBUILD_TESTS=OFF     -DBUILD_TX=ON     -DBUILD_UTIL=OFF     -DCMAKE_BUILD_TYPE=RelWithDebInfo     -DCMAKE_CXX_COMPILER=clang++-16     -DCMAKE_C_COMPILER=clang-16     -DCMAKE_INSTALL_PREFIX:PATH=\"${BITCOIN_PREFIX}\"     -DWITH_CCACHE=ON   && cmake --build build -j$(nproc)   && strip build/bin/bitcoin-cli build/bin/bitcoin-tx build/bin/bitcoind   && cmake --install build" did not complete successfully: exit code: 2

    Building using this branch worked perfectly.

    NB: (unrelated to this PR) that is, until I tried to strip the binaries:

    0[#15](/bitcoin-bitcoin/15/) 105.7 [100%] Built target bitcoind
1[#15](/bitcoin-bitcoin/15/) 105.7 + strip build/bin/bitcoin-cli build/bin/bitcoin-tx build/bin/bitcoind
2[#15](/bitcoin-bitcoin/15/) 105.7 strip: Unable to recognise the format of the input file `build/bin/bitcoin-cli'
3[#15](/bitcoin-bitcoin/15/) 105.7 strip: Unable to recognise the format of the input file `build/bin/bitcoin-tx'
4[#15](/bitcoin-bitcoin/15/) 105.7 strip: Unable to recognise the format of the input file `build/bin/bitcoind'

    I never considered that strip might be platform-specific too… It seems like eu-strip from elfutils can do the job though.

  17. depends: set CMAKE_*_COMPILER_TARGET in toolchain 
    According to the CMake docs, this is the correct way to setup a
toolchain file for cross-compilation using Clang. See
https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-using-clang

Internally it looks like CMake will only take this variable into account
if it detects the compiler to be Clang, so this shouldn't effect other
builds, but in the case of our Apple cross builds, we'd end up with a
duplicated `--target=arm64-apple-darwin` on the compiler line, given we
are already setting `--target` for Darwin builds.

Would fix #31748.
    963355037f
  18. fanquake force-pushed on Mar 23, 2025
  19. hebasto approved
  20. hebasto commented at 11:30 am on March 25, 2025: member
    ACK 963355037fe78eb4fbdda8631ac05a7b07fcec8c, tested on Ubuntu 24.10.
  21. DrahtBot requested review from theuni on Mar 25, 2025
  22. DrahtBot requested review from willcl-ark on Mar 25, 2025
  23. hebasto commented at 4:45 pm on March 25, 2025: member

    My Guix build:

     0aarch64
 102c610ee1471cc2671588a999e5ef914547cd55352ddc084faf7a9a55d79098b  guix-build-963355037fe7/output/aarch64-linux-gnu/SHA256SUMS.part
 211c1779525e0ebfbb55badd50c818cc02ac85a113077cc6074e6d11d4bd98677  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu-debug.tar.gz
 35ef64bbfadca863a09fada8da1b6cf4543c318bb4208f67c7473718c5dec6f55  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu.tar.gz
 480beeb5b6f5b08910e2c3dc0ffc5af3a1542449c4b944f824c1d18083657c080  guix-build-963355037fe7/output/arm-linux-gnueabihf/SHA256SUMS.part
 5c6df0bba1c574e0fd3065c1a1d6cb0551b5063482d24b3830cf813b5caf8326e  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf-debug.tar.gz
 6df2a372f6d2e9cd3018f161bf74b3d14acc3581cca409f258ed6101886f94f93  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf.tar.gz
 79372f0922b80f636b247e4a7c5c1a4e28406335317b21c6a4209d39b14560021  guix-build-963355037fe7/output/arm64-apple-darwin/SHA256SUMS.part
 873c9b0888d7735a623845fdfb63db96681d681f96f742c1fc4b598dfa573bf3d  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-codesigning.tar.gz
 989f9be0bec91b22815f2f3a9d3bdf157c1dbc756fbf3b8b15e65ceb51a21b968  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.tar.gz
10a08a0affd36ca22788604d32840015b96ef1b978a2e29533fd4cdf1e0dbca262  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.zip
114f0150a1a95cefc5c57ba962d54164c59d3fba2e6422d275c9ccbef79a909727  guix-build-963355037fe7/output/dist-archive/bitcoin-963355037fe7.tar.gz
12358d594a07decdb3475383dd7f9108735d594a22d05f59e40a8e48ce9f79030c  guix-build-963355037fe7/output/powerpc64-linux-gnu/SHA256SUMS.part
13dbf2a751f7dc5b18662074dac7a38e99522e2f2fd7d4bc460f4e51c261fe1b2d  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu-debug.tar.gz
141bff2ad47c82eed095250e704357f11b5df6843e72aaaadef47e8f7053557ef2  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu.tar.gz
15e6d455535798882be7ea36571349b0cb240a080954494556ec8a289dc9cfa08e  guix-build-963355037fe7/output/riscv64-linux-gnu/SHA256SUMS.part
16a380ae0fec78c671a06d7354ce9cc074b49bdbd35041a99a9504d5265af628f4  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu-debug.tar.gz
172f706b563997b4ef3297d5b8429d97c537f417a72b04ca853fae21b1a019e85a  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu.tar.gz
18741d20133c46146ee9afaa618ae38947a48bdc64d11d2cf8564eb228c495e431  guix-build-963355037fe7/output/x86_64-apple-darwin/SHA256SUMS.part
191cb1b8319b69203c1ff7c25aa3b5870384066f59a6923d12a9285a3ce3921ee5  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-codesigning.tar.gz
2000dfa559a0ebe3124219801a17522b8b0b1ed3c0961bf3ea03ab1ea7a7e9cb3b  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.tar.gz
2139b8cc81245f20fa37577845eb5fed3644f17da55f8ef32b0d754c7e8ebcf4b9  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.zip
224e46a3c27faf902981012cf7cb0602a472286cf0b45bed65bb9d9daae48c4cc6  guix-build-963355037fe7/output/x86_64-linux-gnu/SHA256SUMS.part
23c447b02d2b4f24348d69316e5306928a3674e2b698c3b437300e9c7927f1e0aa  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu-debug.tar.gz
2414fa59ba892c38b00db08e48615e586a6a9d1f74efa9aaec9860cbdedc9d5be3  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu.tar.gz
25848031e43a9e3e198d4f0b237d72d29b1766c60efd8972a25c9daddc3c7f7758  guix-build-963355037fe7/output/x86_64-w64-mingw32/SHA256SUMS.part
265f6cdd69b1b7425a3cd687b3ed2ba887e7ef49df1b6dfa51d8583e7cea4c570b  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-codesigning.tar.gz
27b8396da5768b19b5d0a2a9f0c4de33f058844d54e49f7fe52cb8643fdc298ca1  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-debug.zip
28b7d05febab0456cf14fc7f0929af917fddd2cc1f6855ba929a42dba26264482a  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-setup-unsigned.exe
29b9f017d2d56e15b5571794e980e078943f10974cc92b6e5e6797c55d22d58419  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-unsigned.zip
  24. fanquake commented at 7:31 am on March 27, 2025: member

    Guix Build (x86_64):

     002c610ee1471cc2671588a999e5ef914547cd55352ddc084faf7a9a55d79098b  guix-build-963355037fe7/output/aarch64-linux-gnu/SHA256SUMS.part
 111c1779525e0ebfbb55badd50c818cc02ac85a113077cc6074e6d11d4bd98677  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu-debug.tar.gz
 25ef64bbfadca863a09fada8da1b6cf4543c318bb4208f67c7473718c5dec6f55  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu.tar.gz
 380beeb5b6f5b08910e2c3dc0ffc5af3a1542449c4b944f824c1d18083657c080  guix-build-963355037fe7/output/arm-linux-gnueabihf/SHA256SUMS.part
 4c6df0bba1c574e0fd3065c1a1d6cb0551b5063482d24b3830cf813b5caf8326e  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf-debug.tar.gz
 5df2a372f6d2e9cd3018f161bf74b3d14acc3581cca409f258ed6101886f94f93  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf.tar.gz
 69372f0922b80f636b247e4a7c5c1a4e28406335317b21c6a4209d39b14560021  guix-build-963355037fe7/output/arm64-apple-darwin/SHA256SUMS.part
 773c9b0888d7735a623845fdfb63db96681d681f96f742c1fc4b598dfa573bf3d  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-codesigning.tar.gz
 889f9be0bec91b22815f2f3a9d3bdf157c1dbc756fbf3b8b15e65ceb51a21b968  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.tar.gz
 9a08a0affd36ca22788604d32840015b96ef1b978a2e29533fd4cdf1e0dbca262  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.zip
104f0150a1a95cefc5c57ba962d54164c59d3fba2e6422d275c9ccbef79a909727  guix-build-963355037fe7/output/dist-archive/bitcoin-963355037fe7.tar.gz
11358d594a07decdb3475383dd7f9108735d594a22d05f59e40a8e48ce9f79030c  guix-build-963355037fe7/output/powerpc64-linux-gnu/SHA256SUMS.part
12dbf2a751f7dc5b18662074dac7a38e99522e2f2fd7d4bc460f4e51c261fe1b2d  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu-debug.tar.gz
131bff2ad47c82eed095250e704357f11b5df6843e72aaaadef47e8f7053557ef2  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu.tar.gz
14e6d455535798882be7ea36571349b0cb240a080954494556ec8a289dc9cfa08e  guix-build-963355037fe7/output/riscv64-linux-gnu/SHA256SUMS.part
15a380ae0fec78c671a06d7354ce9cc074b49bdbd35041a99a9504d5265af628f4  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu-debug.tar.gz
162f706b563997b4ef3297d5b8429d97c537f417a72b04ca853fae21b1a019e85a  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu.tar.gz
17741d20133c46146ee9afaa618ae38947a48bdc64d11d2cf8564eb228c495e431  guix-build-963355037fe7/output/x86_64-apple-darwin/SHA256SUMS.part
181cb1b8319b69203c1ff7c25aa3b5870384066f59a6923d12a9285a3ce3921ee5  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-codesigning.tar.gz
1900dfa559a0ebe3124219801a17522b8b0b1ed3c0961bf3ea03ab1ea7a7e9cb3b  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.tar.gz
2039b8cc81245f20fa37577845eb5fed3644f17da55f8ef32b0d754c7e8ebcf4b9  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.zip
214e46a3c27faf902981012cf7cb0602a472286cf0b45bed65bb9d9daae48c4cc6  guix-build-963355037fe7/output/x86_64-linux-gnu/SHA256SUMS.part
22c447b02d2b4f24348d69316e5306928a3674e2b698c3b437300e9c7927f1e0aa  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu-debug.tar.gz
2314fa59ba892c38b00db08e48615e586a6a9d1f74efa9aaec9860cbdedc9d5be3  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu.tar.gz
24848031e43a9e3e198d4f0b237d72d29b1766c60efd8972a25c9daddc3c7f7758  guix-build-963355037fe7/output/x86_64-w64-mingw32/SHA256SUMS.part
255f6cdd69b1b7425a3cd687b3ed2ba887e7ef49df1b6dfa51d8583e7cea4c570b  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-codesigning.tar.gz
26b8396da5768b19b5d0a2a9f0c4de33f058844d54e49f7fe52cb8643fdc298ca1  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-debug.zip
27b7d05febab0456cf14fc7f0929af917fddd2cc1f6855ba929a42dba26264482a  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-setup-unsigned.exe
28b9f017d2d56e15b5571794e980e078943f10974cc92b6e5e6797c55d22d58419  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-unsigned.zip
  25. fanquake added the label Needs backport (29.x) on Mar 27, 2025
  26. fanquake merged this on Mar 27, 2025
  27. fanquake closed this on Mar 27, 2025
  28. fanquake deleted the branch on Mar 27, 2025
  29. willcl-ark commented at 9:50 am on March 27, 2025: member

    Post-merge ACK 963355037fe78eb4fbdda8631ac05a7b07fcec8c

     0will@ubuntu in …/src/core/bitcoin on  clang_cross_toolchain:refs/pull/31849/head [$?] via △ v3.31.6 : 🐍 (core) took 1h23m21s
 1$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 202c610ee1471cc2671588a999e5ef914547cd55352ddc084faf7a9a55d79098b  guix-build-963355037fe7/output/aarch64-linux-gnu/SHA256SUMS.part
 311c1779525e0ebfbb55badd50c818cc02ac85a113077cc6074e6d11d4bd98677  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu-debug.tar.gz
 45ef64bbfadca863a09fada8da1b6cf4543c318bb4208f67c7473718c5dec6f55  guix-build-963355037fe7/output/aarch64-linux-gnu/bitcoin-963355037fe7-aarch64-linux-gnu.tar.gz
 580beeb5b6f5b08910e2c3dc0ffc5af3a1542449c4b944f824c1d18083657c080  guix-build-963355037fe7/output/arm-linux-gnueabihf/SHA256SUMS.part
 6c6df0bba1c574e0fd3065c1a1d6cb0551b5063482d24b3830cf813b5caf8326e  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf-debug.tar.gz
 7df2a372f6d2e9cd3018f161bf74b3d14acc3581cca409f258ed6101886f94f93  guix-build-963355037fe7/output/arm-linux-gnueabihf/bitcoin-963355037fe7-arm-linux-gnueabihf.tar.gz
 89372f0922b80f636b247e4a7c5c1a4e28406335317b21c6a4209d39b14560021  guix-build-963355037fe7/output/arm64-apple-darwin/SHA256SUMS.part
 973c9b0888d7735a623845fdfb63db96681d681f96f742c1fc4b598dfa573bf3d  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-codesigning.tar.gz
1089f9be0bec91b22815f2f3a9d3bdf157c1dbc756fbf3b8b15e65ceb51a21b968  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.tar.gz
11a08a0affd36ca22788604d32840015b96ef1b978a2e29533fd4cdf1e0dbca262  guix-build-963355037fe7/output/arm64-apple-darwin/bitcoin-963355037fe7-arm64-apple-darwin-unsigned.zip
124f0150a1a95cefc5c57ba962d54164c59d3fba2e6422d275c9ccbef79a909727  guix-build-963355037fe7/output/dist-archive/bitcoin-963355037fe7.tar.gz
13358d594a07decdb3475383dd7f9108735d594a22d05f59e40a8e48ce9f79030c  guix-build-963355037fe7/output/powerpc64-linux-gnu/SHA256SUMS.part
14dbf2a751f7dc5b18662074dac7a38e99522e2f2fd7d4bc460f4e51c261fe1b2d  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu-debug.tar.gz
151bff2ad47c82eed095250e704357f11b5df6843e72aaaadef47e8f7053557ef2  guix-build-963355037fe7/output/powerpc64-linux-gnu/bitcoin-963355037fe7-powerpc64-linux-gnu.tar.gz
16e6d455535798882be7ea36571349b0cb240a080954494556ec8a289dc9cfa08e  guix-build-963355037fe7/output/riscv64-linux-gnu/SHA256SUMS.part
17a380ae0fec78c671a06d7354ce9cc074b49bdbd35041a99a9504d5265af628f4  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu-debug.tar.gz
182f706b563997b4ef3297d5b8429d97c537f417a72b04ca853fae21b1a019e85a  guix-build-963355037fe7/output/riscv64-linux-gnu/bitcoin-963355037fe7-riscv64-linux-gnu.tar.gz
19741d20133c46146ee9afaa618ae38947a48bdc64d11d2cf8564eb228c495e431  guix-build-963355037fe7/output/x86_64-apple-darwin/SHA256SUMS.part
201cb1b8319b69203c1ff7c25aa3b5870384066f59a6923d12a9285a3ce3921ee5  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-codesigning.tar.gz
2100dfa559a0ebe3124219801a17522b8b0b1ed3c0961bf3ea03ab1ea7a7e9cb3b  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.tar.gz
2239b8cc81245f20fa37577845eb5fed3644f17da55f8ef32b0d754c7e8ebcf4b9  guix-build-963355037fe7/output/x86_64-apple-darwin/bitcoin-963355037fe7-x86_64-apple-darwin-unsigned.zip
234e46a3c27faf902981012cf7cb0602a472286cf0b45bed65bb9d9daae48c4cc6  guix-build-963355037fe7/output/x86_64-linux-gnu/SHA256SUMS.part
24c447b02d2b4f24348d69316e5306928a3674e2b698c3b437300e9c7927f1e0aa  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu-debug.tar.gz
2514fa59ba892c38b00db08e48615e586a6a9d1f74efa9aaec9860cbdedc9d5be3  guix-build-963355037fe7/output/x86_64-linux-gnu/bitcoin-963355037fe7-x86_64-linux-gnu.tar.gz
26848031e43a9e3e198d4f0b237d72d29b1766c60efd8972a25c9daddc3c7f7758  guix-build-963355037fe7/output/x86_64-w64-mingw32/SHA256SUMS.part
275f6cdd69b1b7425a3cd687b3ed2ba887e7ef49df1b6dfa51d8583e7cea4c570b  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-codesigning.tar.gz
28b8396da5768b19b5d0a2a9f0c4de33f058844d54e49f7fe52cb8643fdc298ca1  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-debug.zip
29b7d05febab0456cf14fc7f0929af917fddd2cc1f6855ba929a42dba26264482a  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-setup-unsigned.exe
30b9f017d2d56e15b5571794e980e078943f10974cc92b6e5e6797c55d22d58419  guix-build-963355037fe7/output/x86_64-w64-mingw32/bitcoin-963355037fe7-win64-unsigned.zip
  30. glozow referenced this in commit c0756b758f on Mar 28, 2025
  31. glozow commented at 6:35 pm on March 28, 2025: member
    Backported in #32136
  32. glozow removed the label Needs backport (29.x) on Mar 28, 2025


fanquake DrahtBot theuni hebasto willcl-ark glozow


theuni

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-31 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me