doc: add missing copyright headers #31864
pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:copyright_cleanups changing 11 files +24 −16-
fanquake commented at 3:44 pm on February 14, 2025: memberAdd & amends a number of copyright headers. Remove some now obselete doc/code.
-
contrib: remove GPL-3+ from debian/copyright
This is unused.
-
contrib: remove outdated entries from copyright_header.py 47c83e7802
-
doc: add & amend copyright headers 01b9a6183e
-
DrahtBot commented at 3:44 pm on February 14, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31864.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Docs on Feb 14, 2025
-
i-am-yuvi commented at 8:46 am on February 16, 2025: contributorACK 01b9a6183eb58dffac00f053e2742d924c84c721
-
in contrib/devtools/copyright_header.py:25 in 01b9a6183e
21@@ -22,7 +22,6 @@ 22 'src/test/fuzz/FuzzedDataProvider.h', 23 'src/tinyformat.h', 24 'src/bench/nanobench.h', 25- 'test/functional/test_framework/bignum.py',
l0rinc commented at 12:10 pm on February 18, 2025:in src/bench/parse_hex.cpp:1 in 01b9a6183e
0@@ -1,4 +1,4 @@ 1-// Copyright (c) 2024- The Bitcoin Core developers 2+// Copyright (c) 2024-present The Bitcoin Core developers
l0rinc commented at 12:34 pm on February 18, 2025:How were these files chosen for update? I see that many other headers are missing the
-present
part:- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/node/abort.cpp#L1
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/common/args.h#L1
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/bech32.h#L2
and many others have a older end year:
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/bech32.cpp#L2
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/init/bitcoind.cpp#L1
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/ci/test/00_setup_env.sh#L3
or don’t even contain a year:
or have the SPDX header only:
or don’t have any copyright header:
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/test/lint/lint_ignore_dirs.py#L1
- https://github.com/bitcoin/bitcoin/blob/01b9a6183eb58dffac00f053e2742d924c84c721/src/univalue/include/univalue_escapes.h#L1
etc.
in contrib/devtools/copyright_header.py:97 in 01b9a6183e
92@@ -94,7 +93,6 @@ def compile_copyright_regex(copyright_style, year_style, name): 93 r"Satoshi Nakamoto", 94 r"The Bitcoin Core developers", 95 r"BitPay Inc\.", 96- r"University of Illinois at Urbana-Champaign\.",
l0rinc commented at 12:48 pm on February 18, 2025:Only found these in Python dependencies, so: 👍
Unrelated: we could update the script to change the end year to
present
instead
fanquake commented at 6:44 pm on February 20, 2025:I have changes for this locally, but the value is low, and ideally all of this code will soon be removed.l0rinc approvedl0rinc commented at 12:48 pm on February 18, 2025: contributorWhile I admit having stronger feelings against the copyright headers than I should (noise + bikeshedding + revoking right to copy in general), I do value consistency, so it’s a 👍 from me - I wish we could unify more to get rid of this extra source of disagreement, but this PR makes it a bit better, so:
ACK 01b9a6183eb58dffac00f053e2742d924c84c721
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me