cmake: Exclude generated sources from translation #31899

1. 
   hebasto commented at 5:22 pm on February 18, 2025: member

   This PR fixes an error encountered when building the translate target:

   0$ gmake -j $(nproc) -C depends MULTIPROCESS=1
   1$ cmake -G "Unix Makefiles" --preset dev-mode --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake -DWITH_USDT=OFF
   2$ cmake --build build_dev_mode -t translate
   3gmake[3]: *** No rule to make target 'src/test/ipc_test.capnp.c++', needed by 'src/qt/CMakeFiles/translate'. Stop.
   4gmake[2]: *** [CMakeFiles/Makefile2:1646: src/qt/CMakeFiles/translate.dir/all] Error 2
   5gmake[1]: *** [CMakeFiles/Makefile2:1653: src/qt/CMakeFiles/translate.dir/rule] Error 2
   6gmake: *** [Makefile:699: translate] Error 2
   

   The previous attempt to address this issue worked only with Ninja generators and has been reverted.

   Essentially, this PR modifies the translate target so that it ignores generated sources rather than attempting to update them.

   At present, multiprocess-specific sources do not contain any translatable strings. Nonetheless, it is prudent to maintain a general approach.

2. cmake: Exclude generated sources from translation 03b3166aac
3. Revert "cmake: Ensure generated sources are up to date for `translate` target"

   This reverts commit 864386a7444fb5cf16613956ce8bf335f51b67d5.

   ff4ddd3d2e
4. 
   DrahtBot commented at 5:22 pm on February 18, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31899.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label Build system on Feb 18, 2025
6. hebasto added this to the milestone 29.0 on Feb 18, 2025
7. 
   hebasto commented at 5:22 pm on February 18, 2025: member

   This PR fixes an error encountered when building the translate target…

   The issue was reported offline by @pablomartin4btc.

8. TheCharlatan approved
9. 
   TheCharlatan commented at 2:43 pm on February 19, 2025: contributor

   ACK ff4ddd3d2e3b08156fd0a0aeb954fde0a5f4cb03
10. pablomartin4btc approved
11. 
    pablomartin4btc commented at 3:33 pm on February 19, 2025: member

    tACK ff4ddd3d2e3b08156fd0a0aeb954fde0a5f4cb03

    Tested in both Ubuntu and macOS.

12. fanquake merged this on Feb 19, 2025
13. fanquake closed this on Feb 19, 2025

    ---

14. hebasto deleted the branch on Feb 20, 2025

Contributors
hebasto DrahtBot TheCharlatan pablomartin4btc

Labels
Build system

Milestone
29.0