cmake: Exclude generated sources from translation #31899

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250218-translate-target changing 1 files +7 −2
  1. hebasto commented at 5:22 PM on February 18, 2025: member

    This PR fixes an error encountered when building the translate target:

    $ gmake -j $(nproc) -C depends MULTIPROCESS=1
    $ cmake -G "Unix Makefiles" --preset dev-mode --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake -DWITH_USDT=OFF
    $ cmake --build build_dev_mode -t translate
    gmake[3]: *** No rule to make target 'src/test/ipc_test.capnp.c++', needed by 'src/qt/CMakeFiles/translate'. Stop.
    gmake[2]: *** [CMakeFiles/Makefile2:1646: src/qt/CMakeFiles/translate.dir/all] Error 2
    gmake[1]: *** [CMakeFiles/Makefile2:1653: src/qt/CMakeFiles/translate.dir/rule] Error 2
    gmake: *** [Makefile:699: translate] Error 2
    

    The previous attempt to address this issue worked only with Ninja generators and has been reverted.

    Essentially, this PR modifies the translate target so that it ignores generated sources rather than attempting to update them.

    At present, multiprocess-specific sources do not contain any translatable strings. Nonetheless, it is prudent to maintain a general approach.

  2. cmake: Exclude generated sources from translation 03b3166aac
  3. Revert "cmake: Ensure generated sources are up to date for `translate` target"
    This reverts commit 864386a7444fb5cf16613956ce8bf335f51b67d5.
    ff4ddd3d2e
  4. DrahtBot commented at 5:22 PM on February 18, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31899.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, pablomartin4btc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot added the label Build system on Feb 18, 2025
  6. hebasto added this to the milestone 29.0 on Feb 18, 2025
  7. hebasto commented at 5:22 PM on February 18, 2025: member

    This PR fixes an error encountered when building the translate target...

    The issue was reported offline by @pablomartin4btc.

  8. sedited approved
  9. sedited commented at 2:43 PM on February 19, 2025: contributor

    ACK ff4ddd3d2e3b08156fd0a0aeb954fde0a5f4cb03

  10. pablomartin4btc approved
  11. pablomartin4btc commented at 3:33 PM on February 19, 2025: member

    tACK ff4ddd3d2e3b08156fd0a0aeb954fde0a5f4cb03

    Tested in both Ubuntu and macOS.

  12. fanquake merged this on Feb 19, 2025
  13. fanquake closed this on Feb 19, 2025

  14. hebasto deleted the branch on Feb 20, 2025
  15. sedited referenced this in commit f78a01a560 on Feb 22, 2025
  16. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  17. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  18. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  19. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  20. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  21. bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
  22. ivanlele referenced this in commit d960744836 on Apr 16, 2026
  23. Kino1994 referenced this in commit e64b8fbb27 on Jun 28, 2026
  24. BigcoinBGC referenced this in commit f8a7f3425b on Jun 30, 2026
  25. bitcoin locked this on Jul 30, 2026

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-04 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me