Re-create This PR since previous(https://github.com/bitcoin/bitcoin/pull/31902) failed to compile.
Maybe we could re-consider and re-review this after 29.0 branch-off:
random: Initialize variables in hardware RNG functions #31912
pull eval-exec wants to merge 1 commits into bitcoin:master from eval-exec:exec/fix-rndrrs changing 1 files +33 −10-
eval-exec commented at 2:46 AM on February 20, 2025: contributor
-
2498dd8dbd
random: Initialize variables in hardware RNG functions
Signed-off-by: Eval EXEC <execvy@gmail.com>
-
DrahtBot commented at 2:47 AM on February 20, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31912.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #29641 (scripted-diff: Use LogInfo over LogPrintf [WIP, NOMERGE, DRAFT] by maflcko)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
maflcko commented at 7:21 AM on February 20, 2025: member
Has someone tried to report or fix this upstream in the linux kernel or elsewhere? See #31908 (comment)
- maflcko added the label Upstream on Feb 20, 2025
- maflcko added the label Utils/log/libs on Feb 20, 2025
-
giahuy98 commented at 8:41 PM on February 21, 2025: none
2498dd8dbd5acdede03e1a57c5873ca022903023 works on Samsung S25 with the log:
Using RNDR as an additional entropy source. -
maflcko commented at 2:14 PM on March 9, 2025: member
The pull request title and commit message looks off. Also there seems to be an ongoing discussion in #31908 (comment)
-
- maflcko closed this on Apr 11, 2025
